Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead

Committed: https://crrev.com/39245052a1de08122ae972abf0c5ac337168ba8f
Cr-Commit-Position: refs/heads/master@{#374659}

[Srirama, 2016-02-10 12:46:45]

Description was changed from

==========
fix

BUG=
==========

to

==========
Remove unnecessary member variable m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead
==========

[Srirama, 2016-02-10 12:50:50]

srirama.m@samsung.com changed reviewers:
+ fs@opera.com, philipj@opera.com

[Srirama, 2016-02-10 12:50:50]

fs@opera.com: Please review changes in 

philipj@opera.com: Please review changes in

https://codereview.chromium.org/1686063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1686063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3368: if
(!haveVisibleTextTrack && !mediaControls())
Local variable can be removed and use m_closedCaptionsVisible directly but i
kept it for better readability. WDYT? should i remove it as well?

[fs, 2016-02-10 14:29:34]

lgtm

Maybe mention HTMLMediaElement in the subject
(HTMLMediaElement::m_haveVisibleTextTrack if that doesn't overflow.)

https://codereview.chromium.org/1686063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1686063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3368: if
(!haveVisibleTextTrack && !mediaControls())
On 2016/02/10 at 12:50:50, Srirama wrote:
> Local variable can be removed and use m_closedCaptionsVisible directly but i
kept it for better readability. WDYT? should i remove it as well?

I don't mind either way. I think I agree that using the local is slightly more
readable though.

[Srirama, 2016-02-10 14:49:25]

Description was changed from

==========
Remove unnecessary member variable m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead
==========

to

==========
Remove unneeded member variable HTMLMediaElement::m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead
==========

[Srirama, 2016-02-10 14:54:10]

Description was changed from

==========
Remove unneeded member variable HTMLMediaElement::m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead
==========

to

==========
Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead
==========

[Srirama, 2016-02-10 14:54:50]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-02-10 14:55:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1686063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1686063002/1

[commit-bot: I haz the power, 2016-02-10 15:01:09]

Description was changed from

==========
Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead
==========

to

==========
Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead
==========

[commit-bot: I haz the power, 2016-02-10 15:01:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-10 15:02:03]

Description was changed from

==========
Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead
==========

to

==========
Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead

Committed: https://crrev.com/39245052a1de08122ae972abf0c5ac337168ba8f
Cr-Commit-Position: refs/heads/master@{#374659}
==========

[commit-bot: I haz the power, 2016-02-10 15:02:04]

Patchset 1 (id:??) landed as
https://crrev.com/39245052a1de08122ae972abf0c5ac337168ba8f
Cr-Commit-Position: refs/heads/master@{#374659}

[philipj_slow, 2016-02-11 14:41:38]

Post-commit LGTM

https://codereview.chromium.org/1686063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1686063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3368: if
(!haveVisibleTextTrack && !mediaControls())
On 2016/02/10 14:29:34, fs wrote:
> On 2016/02/10 at 12:50:50, Srirama wrote:
> > Local variable can be removed and use m_closedCaptionsVisible directly but i
> kept it for better readability. WDYT? should i remove it as well?
> 
> I don't mind either way. I think I agree that using the local is slightly more
> readable though.

WFM too