Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1685963002: Pass field to mutator thread so that it can be marked as boxed and all dependent code deoptimized (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address reviewer's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index c93a8d67f908c10309915090730c4c594d37dbb9..aaae2431808e47c2ee3b003c2dcbff575c0d0a71 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -4622,7 +4622,9 @@ void FlowGraphOptimizer::VisitStoreInstanceField(
// - set it to unboxed
// - deoptimize dependent code.
if (Compiler::IsBackgroundCompilation()) {
+ isolate()->AddDeoptimizingBoxedField(field);
Compiler::AbortBackgroundCompilation(Thread::kNoDeoptId);
+ UNREACHABLE();
}
if (FLAG_trace_optimization || FLAG_trace_field_guards) {
THR_Print("Disabling unboxing of %s\n", field.ToCString());
@@ -4634,11 +4636,7 @@ void FlowGraphOptimizer::VisitStoreInstanceField(
}
}
field.set_is_unboxing_candidate(false);
- if (Compiler::IsBackgroundCompilation()) {
- UNIMPLEMENTED();
- } else {
- field.DeoptimizeDependentCode();
- }
+ field.DeoptimizeDependentCode();
} else {
FlowGraph::AddToGuardedFields(flow_graph_->guarded_fields(), &field);
}
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698