Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2099)

Unified Diff: runtime/vm/isolate.h

Issue 1685963002: Pass field to mutator thread so that it can be marked as boxed and all dependent code deoptimized (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address reviewer's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index f2a0cc3452f74a0f0124181b0ba21cea51d2e952..ea1efcd5c2f3255f30c0cce619e57acc7fc78a6f 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -53,6 +53,7 @@ class RawMint;
class RawObject;
class RawInteger;
class RawError;
+class RawField;
class RawFloat32x4;
class RawInt32x4;
class RawUserTag;
@@ -642,6 +643,12 @@ class Isolate : public BaseIsolate {
void ResetPrefixInvalidationGen() { prefix_invalidation_gen_ = kInvalidGen; }
uint32_t prefix_invalidation_gen() const { return prefix_invalidation_gen_; }
+ // Used by background compiler which field became boxed and must trigger
+ // deoptimization in the mutator thread.
+ void AddDeoptimizingBoxedField(const Field& field);
+ // Returns Field::null() if none available in the list.
+ RawField* GetDeoptimizingBoxedField();
+
RawObject* InvokePendingServiceExtensionCalls();
void AppendServiceExtensionCall(const Instance& closure,
const String& method_name,
@@ -844,6 +851,11 @@ class Isolate : public BaseIsolate {
uint32_t field_invalidation_gen_;
uint32_t prefix_invalidation_gen_;
+ // Protect access to boxed_field_list_.
+ Monitor* boxed_field_list_monitor_;
+ // List of fields that became boxed and that trigger deoptimization.
+ RawGrowableObjectArray* boxed_field_list_;
+
// This guards spawn_count_. An isolate cannot complete shutdown and be
// destroyed while there are child isolates in the midst of a spawn.
Monitor* spawn_count_monitor_;
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698