Pass field to mutator thread so that it can be marked as boxed and all dependent code deoptimized

Pass field to mutator thread so that it can be marked as boxed and all dependent code deoptimized (background compilation only).

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/d26980f6fc18ba0d832ec648c405ad78726be8a0

[srdjan, 2016-02-10 00:23:42]

Description was changed from

==========
Pass field to mutator thread so that it can be marked as boxed and all dependent
code deoptimized

BUG=
==========

to

==========
Pass field to mutator thread so that it can be marked as boxed and all dependent
code deoptimized (background compilation only).

BUG=
==========

[srdjan, 2016-02-10 00:23:52]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-02-10 17:57:35]

lgtm

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:639: (optimized() && FLAG_print_flow_graph_optimized)) &&
indentation seems off over here.

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:876: delete spawn_count_monitor_;
We seem to have added a number of monitors to the isolate, I am wondering if
some of these can be shared.

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1854:
visitor->VisitPointer(reinterpret_cast<RawObject**>(&boxed_field_list_));
This will work only if the visitor is at a safepoint or is holding the
boxed_field_list_monitor_ lock. Maybe you should document that.

[srdjan, 2016-02-10 19:18:51]

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:639: (optimized() && FLAG_print_flow_graph_optimized)) &&
On 2016/02/10 17:57:35, siva wrote:
> indentation seems off over here.

Done.

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:876: delete spawn_count_monitor_;
On 2016/02/10 17:57:35, siva wrote:
> We seem to have added a number of monitors to the isolate, I am wondering if
> some of these can be shared.

Added a TODO at Isolate constructor:

TODO(srdjan): Some Isolate monitors can be shared. Replace their usage with that
shared monitor.

https://codereview.chromium.org/1685963002/diff/40001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1854:
visitor->VisitPointer(reinterpret_cast<RawObject**>(&boxed_field_list_));
On 2016/02/10 17:57:35, siva wrote:
> This will work only if the visitor is at a safepoint or is holding the
> boxed_field_list_monitor_ lock. Maybe you should document that.

  // 'boxed_field_list_' access via mutator and background compilation threads
  // is guarded with a monitor. This means that we can visit it only
  // when at safepoint or the boxed_field_list_monitor_ lock has been taken.

[srdjan, 2016-02-10 20:33:50]

Description was changed from

==========
Pass field to mutator thread so that it can be marked as boxed and all dependent
code deoptimized (background compilation only).

BUG=
==========

to

==========
Pass field to mutator thread so that it can be marked as boxed and all dependent
code deoptimized (background compilation only).

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d26980f6fc18ba0d832ec648c405ad78726be8a0
==========

[srdjan, 2016-02-10 20:33:51]

Committed patchset #4 (id:60001) manually as
d26980f6fc18ba0d832ec648c405ad78726be8a0 (presubmit successful).