Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart

Issue 1685893002: cpsir: insert guard and force specialization for [] and []= (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/cps_ir/type_propagation.dart ('K') | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | tests/compiler/dart2js/cps_ir/expected/optimize_indexers.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
diff --git a/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart b/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
index b4f6dd88014dc0849bca5b55a1970e0bb9326367..dea683b7b4b93fb6ca6ae015a2df6d404e444164 100644
--- a/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
+++ b/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
@@ -354,6 +354,7 @@ class LogicalRewriter extends RecursiveTransformer
case BuiltinOperator.IsNotNumber:
case BuiltinOperator.IsFloor:
case BuiltinOperator.IsNumberAndFloor:
+ case BuiltinOperator.IsNotInteger:
case BuiltinOperator.Identical:
return true;
default:
@@ -373,6 +374,10 @@ class LogicalRewriter extends RecursiveTransformer
case BuiltinOperator.LooseNeq: return BuiltinOperator.LooseEq;
case BuiltinOperator.IsNumber: return BuiltinOperator.IsNotNumber;
case BuiltinOperator.IsNotNumber: return BuiltinOperator.IsNumber;
+ case BuiltinOperator.IsNumberAndFloor:
+ return BuiltinOperator.IsNotInteger;
+ case BuiltinOperator.IsNotInteger:
+ return BuiltinOperator.IsNumberAndFloor;
// Because of NaN, these do not have a negated form.
case BuiltinOperator.NumLt:
« pkg/compiler/lib/src/cps_ir/type_propagation.dart ('K') | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | tests/compiler/dart2js/cps_ir/expected/optimize_indexers.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698