pkg/compiler/lib/src/js_backend/codegen/codegen.dart - Issue 1685893002: cpsir: insert guard and force specialization for [] and []=

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1685893002: cpsir: insert guard and force specialization for [] and []= (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

index eb1e6994d4ea067c3c39c1f53e7eb9232c212d64..9f9350e8a38ad715c0f0ebd1f640d96bd165131c 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

@@ -1125,6 +1125,8 @@ class CodeGenerator extends tree_ir.StatementVisitor

return js.js('Math.floor(#) === #', args);

case BuiltinOperator.IsNumberAndFloor:

return js.js('typeof # === "number" && Math.floor(#) === #', args);

+ case BuiltinOperator.IsNotInteger:

+ return js.js('typeof # !== "number" || Math.floor(#) !== #', args);

case BuiltinOperator.IsFixedLengthJSArray:

// TODO(sra): Remove boolify (i.e. !!).

return js.js(r'!!#.fixed$length', args);