Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1685883004: Use uint64_t instead of size_t inside the web cache manager code. (Closed)

Created:
4 years, 10 months ago by jam
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use uint64_t instead of size_t inside the web cache manager code. size_t is not sufficient when the browser is 32 bit and the renderers are 64 bits. BUG=581409, 585382 Committed: https://crrev.com/31963689d7f4b2242d4630b34b93852ed03e1dc3 Cr-Commit-Position: refs/heads/master@{#374760}

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 4

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -208 lines) Patch
M chrome/browser/renderer_host/chrome_render_message_filter.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/common/render_messages.h View 3 chunks +6 lines, -15 lines 0 comments Download
M chrome/common/render_messages.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M components/web_cache/browser/web_cache_manager.h View 8 chunks +34 lines, -16 lines 0 comments Download
M components/web_cache/browser/web_cache_manager.cc View 9 chunks +78 lines, -60 lines 0 comments Download
M components/web_cache/browser/web_cache_manager_unittest.cc View 1 2 10 chunks +71 lines, -63 lines 0 comments Download
M components/web_cache/common/web_cache_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/web_cache/renderer/web_cache_render_process_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/web_cache/renderer/web_cache_render_process_observer.cc View 1 2 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jam
Tom: render_messages.* Scott: rest
4 years, 10 months ago (2016-02-10 15:44:18 UTC) #3
sky
LGTM https://codereview.chromium.org/1685883004/diff/20001/components/web_cache/browser/web_cache_manager_unittest.cc File components/web_cache/browser/web_cache_manager_unittest.cc (right): https://codereview.chromium.org/1685883004/diff/20001/components/web_cache/browser/web_cache_manager_unittest.cc#newcode91 components/web_cache/browser/web_cache_manager_unittest.cc:91: const WebCacheManager::RendererInfo& rhs) { nit: run git cl ...
4 years, 10 months ago (2016-02-10 17:05:57 UTC) #4
jam
https://codereview.chromium.org/1685883004/diff/20001/components/web_cache/browser/web_cache_manager_unittest.cc File components/web_cache/browser/web_cache_manager_unittest.cc (right): https://codereview.chromium.org/1685883004/diff/20001/components/web_cache/browser/web_cache_manager_unittest.cc#newcode91 components/web_cache/browser/web_cache_manager_unittest.cc:91: const WebCacheManager::RendererInfo& rhs) { On 2016/02/10 17:05:57, sky wrote: ...
4 years, 10 months ago (2016-02-10 17:52:10 UTC) #5
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-10 17:54:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685883004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685883004/40001
4 years, 10 months ago (2016-02-10 18:00:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/21342)
4 years, 10 months ago (2016-02-10 20:42:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685883004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685883004/40001
4 years, 10 months ago (2016-02-10 21:38:55 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-10 22:55:11 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:00 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/31963689d7f4b2242d4630b34b93852ed03e1dc3
Cr-Commit-Position: refs/heads/master@{#374760}

Powered by Google App Engine
This is Rietveld 408576698