Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: components/web_cache/renderer/web_cache_render_process_observer.cc

Issue 1685883004: Use uint64_t instead of size_t inside the web cache manager code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_cache/renderer/web_cache_render_process_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_cache/renderer/web_cache_render_process_observer.cc
diff --git a/components/web_cache/renderer/web_cache_render_process_observer.cc b/components/web_cache/renderer/web_cache_render_process_observer.cc
index a944ba1ca7784d29f76547a63114475c453dbd28..1d122538b2b6ba567a7f9c39c95ec7ed4fa4ce7d 100644
--- a/components/web_cache/renderer/web_cache_render_process_observer.cc
+++ b/components/web_cache/renderer/web_cache_render_process_observer.cc
@@ -6,6 +6,7 @@
#include <limits>
+#include "base/numerics/safe_conversions.h"
#include "components/web_cache/common/web_cache_messages.h"
#include "third_party/WebKit/public/web/WebCache.h"
@@ -60,18 +61,21 @@ void WebCacheRenderProcessObserver::OnRenderProcessShutdown() {
}
void WebCacheRenderProcessObserver::OnSetCacheCapacities(
- uint32_t min_dead_capacity,
- uint32_t max_dead_capacity,
- uint32_t capacity) {
+ uint64_t min_dead_capacity,
+ uint64_t max_dead_capacity,
+ uint64_t capacity64) {
+ size_t min_dead_capacity2 = base::checked_cast<size_t>(min_dead_capacity);
+ size_t max_dead_capacity2 = base::checked_cast<size_t>(max_dead_capacity);
+ size_t capacity = base::checked_cast<size_t>(capacity64);
if (!webkit_initialized_) {
- pending_cache_min_dead_capacity_ = min_dead_capacity;
- pending_cache_max_dead_capacity_ = max_dead_capacity;
+ pending_cache_min_dead_capacity_ = min_dead_capacity2;
+ pending_cache_max_dead_capacity_ = max_dead_capacity2;
pending_cache_capacity_ = capacity;
return;
}
WebCache::setCapacities(
- min_dead_capacity, max_dead_capacity, capacity);
+ min_dead_capacity2, max_dead_capacity2, capacity);
}
void WebCacheRenderProcessObserver::OnClearCache(bool on_navigation) {
« no previous file with comments | « components/web_cache/renderer/web_cache_render_process_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698