Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168583005: Remove DOMWrapperWorld::isIsolatedWorldId and DOMWrapperWorld::context (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 10 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Remove DOMWrapperWorld::isIsolatedWorldId and DOMWrapperWorld::context These methods are unnecessary. BUG=341032 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167293

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M Source/bindings/v8/DOMWrapperWorld.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 1 2 6 chunks +11 lines, -9 lines 0 comments Download
M Source/bindings/v8/PageScriptDebugServer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptPreprocessor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptPreprocessor.cpp View 1 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
haraken
PTAL
6 years, 10 months ago (2014-02-17 12:42:56 UTC) #1
haraken
On 2014/02/17 12:42:56, haraken wrote: > PTAL Just a moment.
6 years, 10 months ago (2014-02-17 12:44:43 UTC) #2
haraken
On 2014/02/17 12:44:43, haraken wrote: > On 2014/02/17 12:42:56, haraken wrote: > > PTAL > ...
6 years, 10 months ago (2014-02-17 12:49:41 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-17 13:14:38 UTC) #4
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-17 13:22:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/168583005/90001
6 years, 10 months ago (2014-02-17 13:23:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 17:00:24 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12792
6 years, 10 months ago (2014-02-17 17:00:25 UTC) #8
haraken
On 2014/02/17 17:00:25, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-18 01:48:01 UTC) #9
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-18 01:48:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/168583005/90001
6 years, 10 months ago (2014-02-18 01:48:14 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 01:48:31 UTC) #12
Message was sent while issue was closed. 
Change committed as 167293

Powered by Google App Engine
This is Rietveld 408576698