Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc

Issue 16858016: Respect the new Online Wallet sign-in response. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
diff --git a/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc b/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
index c768151d3d609f7892f6bf893813fbb3571b0cd3..74dc6f13073d87324abaa35a7e8e7095c3866e80 100644
--- a/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
+++ b/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
@@ -162,7 +162,14 @@ class WalletSigninHelperTest : public testing::Test {
SetUpFetcherResponseAndCompleteRequest(wallet::GetPassiveAuthUrl().spec(),
200,
net::ResponseCookies(),
- std::string());
+ "YES");
+ }
+
+ void MockFailedPassiveAuthUrlMergeAndRedirectResponseNo() {
+ SetUpFetcherResponseAndCompleteRequest(wallet::GetPassiveAuthUrl().spec(),
+ 200,
ahutter 2013/06/13 23:52:10 Any reason you aren't using net::HTTP_OK?
aruslan 2013/06/18 21:21:47 Done.
+ net::ResponseCookies(),
+ "NOOOO");
}
void MockFailedPassiveAuthUrlMergeAndRedirectResponse404() {
@@ -193,12 +200,18 @@ TEST_F(WalletSigninHelperTest, PassiveSigninSuccessful) {
MockSuccessfulGetAccountInfoResponse("user@gmail.com");
}
-TEST_F(WalletSigninHelperTest, PassiveSigninFailedSignin) {
+TEST_F(WalletSigninHelperTest, PassiveSigninFailedSignin404) {
EXPECT_CALL(mock_delegate_, OnPassiveSigninFailure(_));
signin_helper_->StartPassiveSignin();
MockFailedPassiveAuthUrlMergeAndRedirectResponse404();
}
+TEST_F(WalletSigninHelperTest, PassiveSigninFailedSigninNo) {
+ EXPECT_CALL(mock_delegate_, OnPassiveSigninFailure(_));
+ signin_helper_->StartPassiveSignin();
+ MockFailedPassiveAuthUrlMergeAndRedirectResponseNo();
+}
+
TEST_F(WalletSigninHelperTest, PassiveSigninFailedUserInfo) {
EXPECT_CALL(mock_delegate_, OnPassiveSigninFailure(_));
signin_helper_->StartPassiveSignin();
@@ -239,7 +252,7 @@ TEST_F(WalletSigninHelperTest, AutomaticSigninFailedOAuthLogin) {
MockFailedOAuthLoginResponse404();
}
-TEST_F(WalletSigninHelperTest, AutomaticSigninFailedSignin) {
+TEST_F(WalletSigninHelperTest, AutomaticSigninFailedSignin404) {
EXPECT_CALL(mock_delegate_, OnAutomaticSigninFailure(_));
signin_helper_->StartAutomaticSignin("123SID", "123LSID");
MockSuccessfulGaiaUserInfoResponse("user@gmail.com");
@@ -247,6 +260,14 @@ TEST_F(WalletSigninHelperTest, AutomaticSigninFailedSignin) {
MockFailedPassiveAuthUrlMergeAndRedirectResponse404();
}
+TEST_F(WalletSigninHelperTest, AutomaticSigninFailedSigninNo) {
+ EXPECT_CALL(mock_delegate_, OnAutomaticSigninFailure(_));
+ signin_helper_->StartAutomaticSignin("123SID", "123LSID");
+ MockSuccessfulGaiaUserInfoResponse("user@gmail.com");
+ MockSuccessfulOAuthLoginResponse();
+ MockFailedPassiveAuthUrlMergeAndRedirectResponseNo();
+}
+
// TODO(aruslan): http://crbug.com/188317 Need more tests.
} // namespace wallet

Powered by Google App Engine
This is Rietveld 408576698