Respect the new Online Wallet sign-in response.

components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/browser/wallet/wallet_signin_helper.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/test/base/testing_profile.h"
@@ skipping 144 matching lines @@
         signin_helper_->GetGetAccountInfoUrlForTesting(),
         404,
         net::ResponseCookies(),
         std::string());
   }
 
   void MockSuccessfulPassiveAuthUrlMergeAndRedirectResponse() {
     SetUpFetcherResponseAndCompleteRequest(wallet::GetPassiveAuthUrl().spec(),
                                            200,
                                            net::ResponseCookies(),
-                                           std::string());
+                                           "YES");
+  }
+
+  void MockFailedPassiveAuthUrlMergeAndRedirectResponseNo() {
+    SetUpFetcherResponseAndCompleteRequest(wallet::GetPassiveAuthUrl().spec(),
+                                           200,

[ahutter, 2013/06/13 23:52:10]

Any reason you aren't using net::HTTP_OK?

[aruslan, 2013/06/18 21:21:47]

Done.

+                                           net::ResponseCookies(),
+                                           "NOOOO");
   }
 
   void MockFailedPassiveAuthUrlMergeAndRedirectResponse404() {
     SetUpFetcherResponseAndCompleteRequest(wallet::GetPassiveAuthUrl().spec(),
                                            404,
                                            net::ResponseCookies(),
                                            std::string());
   }
 
   WalletSigninHelperForTesting::State state() const {
@@ skipping 10 matching lines @@
   TestingProfile profile_;
 };
 
 TEST_F(WalletSigninHelperTest, PassiveSigninSuccessful) {
   EXPECT_CALL(mock_delegate_, OnPassiveSigninSuccess("user@gmail.com"));
   signin_helper_->StartPassiveSignin();
   MockSuccessfulPassiveAuthUrlMergeAndRedirectResponse();
   MockSuccessfulGetAccountInfoResponse("user@gmail.com");
 }
 
-TEST_F(WalletSigninHelperTest, PassiveSigninFailedSignin) {
+TEST_F(WalletSigninHelperTest, PassiveSigninFailedSignin404) {
   EXPECT_CALL(mock_delegate_, OnPassiveSigninFailure(_));
   signin_helper_->StartPassiveSignin();
   MockFailedPassiveAuthUrlMergeAndRedirectResponse404();
 }
 
+TEST_F(WalletSigninHelperTest, PassiveSigninFailedSigninNo) {
+  EXPECT_CALL(mock_delegate_, OnPassiveSigninFailure(_));
+  signin_helper_->StartPassiveSignin();
+  MockFailedPassiveAuthUrlMergeAndRedirectResponseNo();
+}
+
 TEST_F(WalletSigninHelperTest, PassiveSigninFailedUserInfo) {
   EXPECT_CALL(mock_delegate_, OnPassiveSigninFailure(_));
   signin_helper_->StartPassiveSignin();
   MockSuccessfulPassiveAuthUrlMergeAndRedirectResponse();
   MockFailedGetAccountInfoResponse404();
 }
 
 TEST_F(WalletSigninHelperTest, PassiveUserInfoSuccessful) {
   EXPECT_CALL(mock_delegate_, OnUserNameFetchSuccess("user@gmail.com"));
   signin_helper_->StartUserNameFetch();
@@ skipping 20 matching lines @@
   MockFailedGaiaUserInfoResponse404();
 }
 
 TEST_F(WalletSigninHelperTest, AutomaticSigninFailedOAuthLogin) {
   EXPECT_CALL(mock_delegate_, OnAutomaticSigninFailure(_));
   signin_helper_->StartAutomaticSignin("123SID", "123LSID");
   MockSuccessfulGaiaUserInfoResponse("user@gmail.com");
   MockFailedOAuthLoginResponse404();
 }
 
-TEST_F(WalletSigninHelperTest, AutomaticSigninFailedSignin) {
+TEST_F(WalletSigninHelperTest, AutomaticSigninFailedSignin404) {
   EXPECT_CALL(mock_delegate_, OnAutomaticSigninFailure(_));
   signin_helper_->StartAutomaticSignin("123SID", "123LSID");
   MockSuccessfulGaiaUserInfoResponse("user@gmail.com");
   MockSuccessfulOAuthLoginResponse();
   MockFailedPassiveAuthUrlMergeAndRedirectResponse404();
 }
 
+TEST_F(WalletSigninHelperTest, AutomaticSigninFailedSigninNo) {
+  EXPECT_CALL(mock_delegate_, OnAutomaticSigninFailure(_));
+  signin_helper_->StartAutomaticSignin("123SID", "123LSID");
+  MockSuccessfulGaiaUserInfoResponse("user@gmail.com");
+  MockSuccessfulOAuthLoginResponse();
+  MockFailedPassiveAuthUrlMergeAndRedirectResponseNo();
+}
+
 // TODO(aruslan): http://crbug.com/188317 Need more tests.
 
 }  // namespace wallet
 }  // namespace autofill