Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1685773002: Sk4f: add floor() (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk4f: add floor() BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1685773002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/86c6c4935171a1d2d6a9ffbff37ec6dac1326614 CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release-Trybot,Test-Android-GCC-Nexus9-GPU-TegraK1-Arm64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/126626e52310b39429ad5eaa8e68e0caa24e6202

Patch Set 1 #

Patch Set 2 : qqq #

Patch Set 3 : add a bench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1 line) Patch
M bench/Sk4fBench.cpp View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/core/SkNx.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/opts/SkNx_neon.h View 1 2 chunks +19 lines, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 2 chunks +12 lines, -0 lines 0 comments Download
M tests/SkNxTest.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685773002/1
4 years, 10 months ago (2016-02-09 19:52:39 UTC) #3
mtklein_C
4 years, 10 months ago (2016-02-09 19:52:43 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/4319) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
4 years, 10 months ago (2016-02-09 19:53:38 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685773002/20001
4 years, 10 months ago (2016-02-09 19:54:52 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 20:32:49 UTC) #11
herb_g
lgtm
4 years, 10 months ago (2016-02-09 21:14:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685773002/40001
4 years, 10 months ago (2016-02-09 21:17:05 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/86c6c4935171a1d2d6a9ffbff37ec6dac1326614
4 years, 10 months ago (2016-02-09 21:46:55 UTC) #17
mtklein
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1679343004/ by mtklein@google.com. ...
4 years, 10 months ago (2016-02-09 23:10:47 UTC) #18
mtklein
oh, maybe not this CL after all. will land again with some extra trybots to ...
4 years, 10 months ago (2016-02-09 23:40:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685773002/40001
4 years, 10 months ago (2016-02-09 23:41:01 UTC) #24
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 23:41:39 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/126626e52310b39429ad5eaa8e68e0caa24e6202

Powered by Google App Engine
This is Rietveld 408576698