Enable coredumps for dart2js unit tests on buildbot.

Enable coredumps for dart2js unit tests on buildbot.

BUG=
R=ricow@google.com

Committed: https://github.com/dart-lang/sdk/commit/5c8b76734c372a3a5f82690bf21e6f6ba4b4a10b

[Bill Hesse, 2016-02-11 13:29:50]

whesse@google.com changed reviewers:
+ kustermann@google.com

[ricow1, 2016-02-11 13:39:52]

ricow@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2016-02-11 13:39:52]

lgtm

[Bill Hesse, 2016-02-11 13:44:19]

Description was changed from

==========
Enable coredumps for dart2js unit tests on buildbot.

BUG=
==========

to

==========
Enable coredumps for dart2js unit tests on buildbot.

BUG=
R=ricow@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5c8b76734c372a3a5f82690bf21e6f6ba4b4a10b
==========

[Bill Hesse, 2016-02-11 13:44:21]

Committed patchset #1 (id:1) manually as
5c8b76734c372a3a5f82690bf21e6f6ba4b4a10b (presubmit successful).

[kustermann, 2016-02-11 13:45:19]

LGTM

But this does not add archiving functionality. Where is that code?

We use a [CoredumpArchiver] class in dartino to do this for us (it also limits
the number of coredumps we upload).

https://codereview.chromium.org/1685743004/diff/1/tools/bots/compiler.py
File tools/bots/compiler.py (right):

https://codereview.chromium.org/1685743004/diff/1/tools/bots/compiler.py#newc...
tools/bots/compiler.py:290: unit_test_flags, arch)
Is it intentionally only for 'd8' runtime?

[kustermann, 2016-02-11 13:45:19]

LGTM

But this does not add archiving functionality. Where is that code?

We use a [CoredumpArchiver] class in dartino to do this for us (it also limits
the number of coredumps we upload).

https://codereview.chromium.org/1685743004/diff/1/tools/bots/compiler.py
File tools/bots/compiler.py (right):

https://codereview.chromium.org/1685743004/diff/1/tools/bots/compiler.py#newc...
tools/bots/compiler.py:290: unit_test_flags, arch)
Is it intentionally only for 'd8' runtime?

[Bill Hesse, 2016-02-11 13:48:23]

On 2016/02/11 13:45:19, kustermann wrote:
> LGTM
> 
> But this does not add archiving functionality. Where is that code?
> 
> We use a [CoredumpArchiver] class in dartino to do this for us (it also limits
> the number of coredumps we upload).
> 
> https://codereview.chromium.org/1685743004/diff/1/tools/bots/compiler.py
> File tools/bots/compiler.py (right):
> 
>
https://codereview.chromium.org/1685743004/diff/1/tools/bots/compiler.py#newc...
> tools/bots/compiler.py:290: unit_test_flags, arch)
> Is it intentionally only for 'd8' runtime?

This is intentionally a limited change, that just enables coredumps, without
archiving, on the few bots that run the dart2js unit tests, to diagnose a
failure, and will be removed, along with the --abort-on-assert-failure flag to
the VM that was added for this purpose.

We would like to add the coredump archiving class at some time in the future,
and enable it on some bots.