Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: tools/bots/compiler.py

Issue 1685743004: Enable coredumps for dart2js unit tests on buildbot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bots/bot_utils.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
diff --git a/tools/bots/compiler.py b/tools/bots/compiler.py
index 61d0a204243c1f21636c4adf3886d7bf6514b2e4..382646f997a95345da443dd60d87dad6adf8c8ad 100644
--- a/tools/bots/compiler.py
+++ b/tools/bots/compiler.py
@@ -20,6 +20,7 @@ import subprocess
import sys
import bot
+import bot_utils
DARTIUM_BUILDER = r'none-dartium-(linux|mac|windows)'
DART2JS_BUILDER = (
@@ -284,8 +285,9 @@ def TestCompiler(runtime, mode, system, flags, is_buildbot, arch,
# The dart2js compiler isn't self-hosted (yet) so we run its
# unit tests on the VM. We avoid doing this on the builders
# that run the browser tests to cut down on the cycle time.
- TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js', 'try'],
- unit_test_flags, arch)
+ with bot_utils.CoredumpEnabler():
+ TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js', 'try'],
+ unit_test_flags, arch)
kustermann 2016/02/11 13:45:19 Is it intentionally only for 'd8' runtime?
if compiler == 'dart2js' and runtime == 'drt':
# Ensure that we run the "try" tests on Content Shell.
« no previous file with comments | « tools/bots/bot_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698