Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: libyuv_test.gyp

Issue 1685723002: add 'LIBYUV_DISABLE_X86' to msan for unittests (Closed) Base URL: https://chromium.googlesource.com/libyuv/libyuv@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/libyuv/version.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libyuv_test.gyp
diff --git a/libyuv_test.gyp b/libyuv_test.gyp
index 0037106679e1b093c3efe27a0544d8db0e9ee248..d60550b4811108b7eb5a59d71953afc73a055446 100644
--- a/libyuv_test.gyp
+++ b/libyuv_test.gyp
@@ -27,6 +27,15 @@
'export_dependent_settings': [
'<(DEPTH)/testing/gtest.gyp:gtest',
],
+ 'conditions': [
+ # MemorySanitizer does not support assembly code yet.
+ # http://crbug.com/344505
+ [ 'msan == 1', {
+ 'defines': [
+ 'LIBYUV_DISABLE_X86',
+ ],
+ }],
+ ], #conditions
harryjin 2016/02/09 19:11:44 I suppose you put it here to make it clear what th
fbarchard1 2016/02/09 19:14:35 The comment #conditions? yes its for clarity. ca
'defines': [
# Enable the following 3 macros to turn off assembly for specified CPU.
# 'LIBYUV_DISABLE_X86',
« no previous file with comments | « include/libyuv/version.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698