add 'LIBYUV_DISABLE_X86' to msan for unittests

libyuv_test.gyp

 # Copyright 2011 The LibYuv Project Authors. All rights reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS. All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 {
   'variables': {
     'libyuv_disable_jpeg%': 0,
   },
   'targets': [
     {
       'target_name': 'libyuv_unittest',
       'type': '<(gtest_target_type)',
       'dependencies': [
         'libyuv.gyp:libyuv',
         'testing/gtest.gyp:gtest',
         'third_party/gflags/gflags.gyp:gflags',
       ],
       'direct_dependent_settings': {
         'defines': [
           'GTEST_RELATIVE_PATH',
         ],
       },
       'export_dependent_settings': [
         '<(DEPTH)/testing/gtest.gyp:gtest',
       ],
+      'conditions': [
+        # MemorySanitizer does not support assembly code yet.
+        # http://crbug.com/344505
+        [ 'msan == 1', {
+          'defines': [
+            'LIBYUV_DISABLE_X86',
+          ],
+        }],
+      ], #conditions

[harryjin, 2016/02/09 19:11:44]

I suppose you put it here to make it clear what the bracket is paired with. But
this is unconventional in a build file.

[fbarchard1, 2016/02/09 19:14:35]

The comment #conditions?  yes its for clarity.  can be hard to see the brackets
paired when there are many conditions.

       'defines': [
         # Enable the following 3 macros to turn off assembly for specified CPU.
         # 'LIBYUV_DISABLE_X86',
         # 'LIBYUV_DISABLE_NEON',
         # 'LIBYUV_DISABLE_MIPS',
         # Enable the following macro to build libyuv as a shared library (dll).
         # 'LIBYUV_USING_SHARED_LIBRARY',
       ],
       'sources': [
         # headers
@@ skipping 172 matching lines @@
       ],
     }],
   ],
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: