add 'LIBYUV_DISABLE_X86' to msan for unittests

add 'LIBYUV_DISABLE_X86' to msan for unittests

R=harryjin@google.com
BUG=libyuv:564
Committed: https://chromium.googlesource.com/libyuv/libyuv/+/6ea3755330fcd8e5531e341c5460fe147324ccbd

[harryjin, 2016-02-09 19:11:44]

https://codereview.chromium.org/1685723002/diff/1/libyuv_test.gyp
File libyuv_test.gyp (right):

https://codereview.chromium.org/1685723002/diff/1/libyuv_test.gyp#newcode38
libyuv_test.gyp:38: ], #conditions
I suppose you put it here to make it clear what the bracket is paired with. But
this is unconventional in a build file.

[fbarchard1, 2016-02-09 19:14:35]

https://codereview.chromium.org/1685723002/diff/1/libyuv_test.gyp
File libyuv_test.gyp (right):

https://codereview.chromium.org/1685723002/diff/1/libyuv_test.gyp#newcode38
libyuv_test.gyp:38: ], #conditions
On 2016/02/09 19:11:44, harryjin wrote:
> I suppose you put it here to make it clear what the bracket is paired with.
But
> this is unconventional in a build file.

The comment #conditions?  yes its for clarity.  can be hard to see the brackets
paired when there are many conditions.

[fbarchard1, 2016-02-09 19:21:05]

msan builds are currently failing with the following unittest link errors

bj/chromium/src/third_party/libjpeg_turbo/libjpeg_turbo.a -Wl,--end-group 
-Llib/
../../unit_test/math_test.cc:30: error: undefined reference to 'FixedDiv_X86'
../../unit_test/math_test.cc:31: error: undefined reference to 'FixedDiv_X86'
../../unit_test/math_test.cc:36: error: undefined reference to 'FixedDiv_X86'
../../unit_test/math_test.cc:37: error: undefined reference to 'FixedDiv_X86'
../../unit_test/math_test.cc:142: error: undefined reference to 'FixedDiv1_X86'
../../unit_test/planar_test.cc:1364: error: undefined reference to
'ARGBAffineRow_SSE2'
../../unit_test/planar_test.cc:1371: error: undefined reference to
'ARGBAffineRow_SSE2'
../../unit_test/planar_test.cc:1402: error: undefined reference to
'SobelXRow_SSE2'
../../unit_test/planar_test.cc:1439: error: undefined reference to
'SobelYRow_SSE2'
../../unit_test/planar_test.cc:1483: error: undefined reference to
'SobelRow_SSE2'
../../unit_test/planar_test.cc:1521: error: undefined reference to
'SobelToPlaneRow_SSE2'
../../unit_test/planar_test.cc:1561: error: undefined reference to
'SobelXYRow_SSE2'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

This is because the library is built with LIBYUV_DISABLE_X86 which removed those
functions, but the unittests are build without the flag, so they attempt to call
those functions.

[harryjin, 2016-02-09 19:21:15]

lgtm

[fbarchard1, 2016-02-09 19:23:15]

warning:
gyp: Key 'conditions' repeated at level 3 with key path 'targets.0' while
reading libyuv_test.gyp

[fbarchard1, 2016-02-09 19:37:59]

[----------] Global test environment tear-down
[==========] 974 tests from 6 test cases ran. (305783 ms total)
[  PASSED  ] 974 tests.

  YOU HAVE 86 DISABLED TESTS

[fbarchard1, 2016-02-09 19:56:41]

try bots pass.

[fbarchard1, 2016-02-09 19:57:06]

Description was changed from

==========
add 'LIBYUV_DISABLE_X86' to msan for unittests

R=harryjin@google.com
BUG=libyuv:564
==========

to

==========
add 'LIBYUV_DISABLE_X86' to msan for unittests

R=harryjin@google.com
BUG=libyuv:564

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/6ea3755330fcd8e5531e341c546...
==========

[fbarchard1, 2016-02-09 19:57:07]

Committed patchset #4 (id:60001) manually as
6ea3755330fcd8e5531e341c5460fe147324ccbd (presubmit successful).

[kjellander_chromium, 2016-02-09 20:08:07]

kjellander@chromium.org changed reviewers:
+ kjellander@chromium.org

[kjellander_chromium, 2016-02-09 20:08:08]

lgtm with a suggestion.

Running ./gyp_libyuv worked for me without any issues

https://codereview.chromium.org/1685723002/diff/60001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1685723002/diff/60001/.gitignore#newcode80
.gitignore:80: /tools/gritsettings/README
Just add the directory, not the files, that'll reduce future maintenance. 

Same below.