Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1685503002: Fix closure compile by fixing @typedef in cr.js (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
dpapad
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compile by fixing @typedef in cr.js R=dpapad@chromium.org BUG=none TEST=green closure bots NOTRY=true Committed: https://crrev.com/5b8884b3895b5135606be57174a69730eb139ad0 Cr-Commit-Position: refs/heads/master@{#374275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M ui/webui/resources/js/cr.js View 2 chunks +3 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Dan Beam
4 years, 10 months ago (2016-02-09 02:13:06 UTC) #1
dpapad
lgtm
4 years, 10 months ago (2016-02-09 02:14:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685503002/1
4 years, 10 months ago (2016-02-09 02:15:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 02:29:34 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 02:30:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b8884b3895b5135606be57174a69730eb139ad0
Cr-Commit-Position: refs/heads/master@{#374275}

Powered by Google App Engine
This is Rietveld 408576698