Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 1681053002: Unrestrict version of PolymerElements/iron-list and update it (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
dpapad
CC:
aboxhall, arv+watch_chromium.org, chromium-reviews, dbeam+watch-closure_chromium.org, egarciad_google.com, jlklein+watch-closure_chromium.org, michaelpg+watch-polymer_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-closure
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unrestrict version of PolymerElements/iron-list and update it Also pulls in whatever happened in the last few day in Polymer R=dpapad@chromium.org BUG=none NOPRESUBMIT=true # crisper.js Committed: https://crrev.com/82518f51af928f359dc51011a56ae221b9ff9508 Cr-Commit-Position: refs/heads/master@{#374455}

Patch Set 1 #

Total comments: 2

Patch Set 2 : and vulcanize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2608 lines, -1950 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 8 chunks +2136 lines, -1711 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_history/compiled_resources.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/.bower.json View 2 chunks +14 lines, -12 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/README.md View 6 chunks +32 lines, -12 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/bower.json View 2 chunks +10 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html View 7 chunks +38 lines, -16 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js View 40 chunks +300 lines, -138 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/.bower.json View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/CONTRIBUTING.md View 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/README.md View 3 chunks +26 lines, -20 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/bower.json View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 2 chunks +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
Dan Beam
https://codereview.chromium.org/1681053002/diff/1/chrome/test/data/webui/md_history/md_history_browsertest.js File chrome/test/data/webui/md_history/md_history_browsertest.js (right): https://codereview.chromium.org/1681053002/diff/1/chrome/test/data/webui/md_history/md_history_browsertest.js#newcode26 chrome/test/data/webui/md_history/md_history_browsertest.js:26: runAccessibilityChecks: false, this is the fix to allow us ...
4 years, 10 months ago (2016-02-09 04:27:59 UTC) #2
dpapad
lgtm
4 years, 10 months ago (2016-02-09 17:43:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681053002/20001
4 years, 10 months ago (2016-02-09 19:21:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144314)
4 years, 10 months ago (2016-02-09 19:38:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681053002/20001
4 years, 10 months ago (2016-02-09 20:19:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-09 20:29:27 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:30:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82518f51af928f359dc51011a56ae221b9ff9508
Cr-Commit-Position: refs/heads/master@{#374455}

Powered by Google App Engine
This is Rietveld 408576698