Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1685363002: Add a platform plugin infrastructure. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a platform plugin infrastructure. This is basically the minimum Flutter needs to stop doing manual serialization stuff. This also migrates the VM loader to use the plugin infrastructure. In a follow-up commit, I plan to migrate the browser loader as well. That will likely require some additional modifications to the plugin API to support the more complex use-case. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/e270e07393dc638d961677394fff0184f05279ef

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+644 lines, -920 lines) Patch
M lib/pub_serve.dart View 1 chunk +15 lines, -9 lines 0 comments Download
M lib/src/backend/invoker.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/runner/debugger.dart View 2 chunks +1 line, -2 lines 0 comments Download
M lib/src/runner/environment.dart View 1 chunk +3 lines, -0 lines 0 comments Download
D lib/src/runner/hack_load_vm_file_hook.dart View 1 chunk +0 lines, -21 lines 0 comments Download
M lib/src/runner/load_suite.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/loader.dart View 5 chunks +36 lines, -133 lines 0 comments Download
A lib/src/runner/plugin/environment.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A lib/src/runner/plugin/platform.dart View 1 chunk +180 lines, -0 lines 0 comments Download
A lib/src/runner/plugin/remote_platform_helpers.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A lib/src/runner/remote_listener.dart View 1 2 1 chunk +191 lines, -0 lines 0 comments Download
A + lib/src/runner/runner_test.dart View 3 chunks +16 lines, -25 lines 0 comments Download
A lib/src/runner/vm/catch_isolate_errors.dart View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
D lib/src/runner/vm/environment.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D lib/src/runner/vm/isolate_listener.dart View 1 chunk +0 lines, -184 lines 0 comments Download
D lib/src/runner/vm/isolate_test.dart View 1 chunk +0 lines, -93 lines 0 comments Download
A lib/src/runner/vm/platform.dart View 1 chunk +97 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 3 chunks +3 lines, -3 lines 0 comments Download
M test/runner/engine_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
D test/runner/isolate_listener_test.dart View 1 chunk +0 lines, -412 lines 0 comments Download
M test/runner/load_suite_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M test/utils.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 10 months ago (2016-02-11 01:48:43 UTC) #1
kevmoo
LGTM https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/plugin/platform.dart File lib/src/runner/plugin/platform.dart (right): https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/plugin/platform.dart#newcode114 lib/src/runner/plugin/platform.dart:114: suiteChannel.stream.listen((response) { Couldn't be done with `await for`? ...
4 years, 10 months ago (2016-02-11 19:57:50 UTC) #2
nweiz
Code review changes
4 years, 10 months ago (2016-02-11 21:28:38 UTC) #3
nweiz
Committed patchset #3 (id:40001) manually as e270e07393dc638d961677394fff0184f05279ef (presubmit successful).
4 years, 10 months ago (2016-02-11 21:28:50 UTC) #5
nweiz
4 years, 10 months ago (2016-02-11 21:29:18 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/plugin/p...
File lib/src/runner/plugin/platform.dart (right):

https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/plugin/p...
lib/src/runner/plugin/platform.dart:114: suiteChannel.stream.listen((response) {
On 2016/02/11 19:57:49, kevmoo wrote:
> Couldn't be done with `await for`?

No; we don't want to block the method on the stream closing. Also, "await for"
doesn't support good error handling.

https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/remote_l...
File lib/src/runner/remote_listener.dart (right):

https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/remote_l...
lib/src/runner/remote_listener.dart:6: import 'dart:developer';
On 2016/02/11 19:57:50, kevmoo wrote:
> unused import

Done.

https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/remote_l...
lib/src/runner/remote_listener.dart:8: import 'package:async/async.dart';
On 2016/02/11 19:57:50, kevmoo wrote:
> unused import

Done.

https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/vm/catch...
File lib/src/runner/vm/catch_isolate_errors.dart (right):

https://codereview.chromium.org/1685363002/diff/20001/lib/src/runner/vm/catch...
lib/src/runner/vm/catch_isolate_errors.dart:10: import
'../../backend/declarer.dart';
On 2016/02/11 19:57:50, kevmoo wrote:
> All of these seem to be unused imports...

Done.

Powered by Google App Engine
This is Rietveld 408576698