Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1890)

Unified Diff: lib/src/backend/invoker.dart

Issue 1685363002: Add a platform plugin infrastructure. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/pub_serve.dart ('k') | lib/src/runner/browser/browser_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/backend/invoker.dart
diff --git a/lib/src/backend/invoker.dart b/lib/src/backend/invoker.dart
index 9644d847fc7e44cbaf542357ae796d566012067c..0a0a31846fb34e740fac30b4687b26379dd9cff7 100644
--- a/lib/src/backend/invoker.dart
+++ b/lib/src/backend/invoker.dart
@@ -8,6 +8,7 @@ import 'package:stack_trace/stack_trace.dart';
import '../backend/group.dart';
import '../frontend/expect.dart';
+import '../runner/load_suite.dart';
import '../utils.dart';
import 'closed_exception.dart';
import 'live_test.dart';
@@ -246,6 +247,14 @@ class Invoker {
// If a test was marked as success but then had an error, that indicates
// that it was poorly-written and could be flaky.
if (!afterSuccess) return;
+
+ // However, users don't think of load tests as "tests", so the error isn't
+ // helpful for them.
+ //
+ // TODO(nweiz): Find a way of avoiding this error that doesn't require
+ // Invoker to refer to a class from the runner.
+ if (liveTest.suite is LoadSuite) return;
+
_handleError(
"This test failed after it had already completed. Make sure to use "
"[expectAsync]\n"
« no previous file with comments | « lib/pub_serve.dart ('k') | lib/src/runner/browser/browser_manager.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698