Issue 16853005: Fix bug in constant propagation with double-equality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16853005: Fix bug in constant propagation with double-equality. (Closed)

Created:
7 years, 6 months ago by Florian Schneider

Modified:
7 years, 6 months ago

Reviewers:
Kevin Millikin (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix bug in constant propagation with double-equality. Don't optimize x == x and x != x if x is a double: x == x is not true, if x == NaN. TEST=tests/language/arithmetic_test.dart R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=23955

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/language/arithmetic_test.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

7 years, 6 months ago (2013-06-13 09:08:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23955 (presubmit successful).