Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 16851002: Implement minified MirrorSystem.getName. (Closed)

Created:
6 years, 7 months ago by ahe
Modified:
6 years, 7 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, ngeoffray, kasperl, Johnni Winther, karlklose
Visibility:
Public.

Description

Implement minified MirrorSystem.getName. BUG=http://dartbug.com/11218 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=24180

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Address Kasper's comments #

Patch Set 3 : Merged with HEAD and reused code. #

Patch Set 4 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -83 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 2 4 chunks +39 lines, -9 lines 0 comments Download
M dart/sdk/lib/_internal/lib/js_helper.dart View 4 chunks +29 lines, -5 lines 0 comments Download
M dart/sdk/lib/_internal/lib/js_mirrors.dart View 1 2 4 chunks +5 lines, -69 lines 0 comments Download
A dart/sdk/lib/_internal/lib/js_names.dart View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/libraries.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A dart/tests/lib/mirrors/get_symbol_name_no_such_method_test.dart View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
Please review now, I'll add a test later (I've been using the example from http://dartbug.com/11218 ...
6 years, 7 months ago (2013-06-19 07:16:51 UTC) #1
kasperl
LGTM. Let me know when you have tests to look at too. https://codereview.chromium.org/16851002/diff/10001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ...
6 years, 7 months ago (2013-06-19 09:19:50 UTC) #2
ahe
Thank you, Kasper! https://codereview.chromium.org/16851002/diff/10001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/16851002/diff/10001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1214 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1214: String getReflectionName(/* Element or Selector */ ...
6 years, 7 months ago (2013-06-19 12:20:58 UTC) #3
ahe
Added a test. I'll submit now and address any concerns in a follow-up CL.
6 years, 7 months ago (2013-06-19 12:56:09 UTC) #4
ahe
Committed patchset #4 manually as r24180 (presubmit successful).
6 years, 7 months ago (2013-06-19 12:56:35 UTC) #5
kasperl
6 years, 7 months ago (2013-06-20 06:34:28 UTC) #6
Message was sent while issue was closed.
Test LGTM too.

Powered by Google App Engine
This is Rietveld 408576698