Revert of Reland Fix leak PaintLayerReflectionInfo

Revert of Reland Fix leak PaintLayerReflectionInfo (patchset #2 id:20001 of https://codereview.chromium.org/1681663003/ )

Reason for revert:
I suspect this broke webkit_unit_tests on Mac Asan (https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/11738/steps/webkit_unit_tests/logs/All_ParameterizedWebFrameTest.CompositedSelectionBoundsCleared_1). Will reland if not the culprit.

Failure snippet:

[ RUN      ] All/ParameterizedWebFrameTest.CompositedSelectionBoundsCleared/1
=================================================================
==37555==ERROR: AddressSanitizer: heap-use-after-free on address 0x610000001b50 at pc 0x00010b1599b5 bp 0x7fff5bb669d0 sp 0x7fff5bb669c8
READ of size 8 at 0x610000001b50 thread T0
    #0 0x10b1599b4 in blink::PaintLayerScrollableArea::scrollbarsCanBeActive() const (in webkit_unit_tests) + 420
    #1 0x105dd885b in blink::ScrollAnimatorMac::updateScrollerStyle() (in webkit_unit_tests) + 283

Original issue's description:
> Reland Fix leak PaintLayerReflectionInfo
>
> NOT FOR COMMIT, YET
>
> Originally https://codereview.chromium.org/1657883002/
> Patch by wangxianzhu@
>
> Previously PaintLayerReflectionInfo required destroy() to be called
> before destruction, but we missed the call in
> PaintLayer::updateReflectionInfo(), causing leak of the reflection
> layout object and the layer for the reflection.
>
> Delete PaintLayerReflectionInfo::destroy(). Use destructor instead.
>
> BUG=582717
> TEST=PaintLayerTest.ReflectionLeak
>
> Committed: https://crrev.com/6137b72d44c0391a39e2a8f9cad9efb4706880e9
> Cr-Commit-Position: refs/heads/master@{#374556}

TBR=pdr@chromium.org,chrishtr@chromium.org,rnk@chromium.org,hans@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582717
Committed: https://crrev.com/e0094729c3804d4b4c8a28d81148def71d4e4e40
Cr-Commit-Position: refs/heads/master@{#374633}

[blundell, 2016-02-10 10:09:32]

Created Revert of Reland Fix leak PaintLayerReflectionInfo

[commit-bot: I haz the power, 2016-02-10 10:09:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685073002/1

[commit-bot: I haz the power, 2016-02-10 10:10:26]

Description was changed from

==========
Revert of Reland Fix leak PaintLayerReflectionInfo (patchset #2 id:20001 of
https://codereview.chromium.org/1681663003/ )

Reason for revert:
I suspect this broke webkit_unit_tests on Mac Asan
(https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...).
Will reland if not the culprit.

Failure snippet:

[ RUN      ] All/ParameterizedWebFrameTest.CompositedSelectionBoundsCleared/1
=================================================================
==37555==ERROR: AddressSanitizer: heap-use-after-free on address 0x610000001b50
at pc 0x00010b1599b5 bp 0x7fff5bb669d0 sp 0x7fff5bb669c8
READ of size 8 at 0x610000001b50 thread T0
    #0 0x10b1599b4 in blink::PaintLayerScrollableArea::scrollbarsCanBeActive()
const (in webkit_unit_tests) + 420
    #1 0x105dd885b in blink::ScrollAnimatorMac::updateScrollerStyle() (in
webkit_unit_tests) + 283



Original issue's description:
> Reland Fix leak PaintLayerReflectionInfo
> 
> NOT FOR COMMIT, YET
> 
> Originally https://codereview.chromium.org/1657883002/
> Patch by wangxianzhu@
> 
> Previously PaintLayerReflectionInfo required destroy() to be called
> before destruction, but we missed the call in
> PaintLayer::updateReflectionInfo(), causing leak of the reflection
> layout object and the layer for the reflection.
> 
> Delete PaintLayerReflectionInfo::destroy(). Use destructor instead.
> 
> BUG=582717
> TEST=PaintLayerTest.ReflectionLeak
> 
> Committed: https://crrev.com/6137b72d44c0391a39e2a8f9cad9efb4706880e9
> Cr-Commit-Position: refs/heads/master@{#374556}

TBR=pdr@chromium.org,chrishtr@chromium.org,rnk@chromium.org,hans@chromium.org...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582717
==========

to

==========
Revert of Reland Fix leak PaintLayerReflectionInfo (patchset #2 id:20001 of
https://codereview.chromium.org/1681663003/ )

Reason for revert:
I suspect this broke webkit_unit_tests on Mac Asan
(https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...).
Will reland if not the culprit.

Failure snippet:

[ RUN      ] All/ParameterizedWebFrameTest.CompositedSelectionBoundsCleared/1
=================================================================
==37555==ERROR: AddressSanitizer: heap-use-after-free on address 0x610000001b50
at pc 0x00010b1599b5 bp 0x7fff5bb669d0 sp 0x7fff5bb669c8
READ of size 8 at 0x610000001b50 thread T0
    #0 0x10b1599b4 in blink::PaintLayerScrollableArea::scrollbarsCanBeActive()
const (in webkit_unit_tests) + 420
    #1 0x105dd885b in blink::ScrollAnimatorMac::updateScrollerStyle() (in
webkit_unit_tests) + 283



Original issue's description:
> Reland Fix leak PaintLayerReflectionInfo
> 
> NOT FOR COMMIT, YET
> 
> Originally https://codereview.chromium.org/1657883002/
> Patch by wangxianzhu@
> 
> Previously PaintLayerReflectionInfo required destroy() to be called
> before destruction, but we missed the call in
> PaintLayer::updateReflectionInfo(), causing leak of the reflection
> layout object and the layer for the reflection.
> 
> Delete PaintLayerReflectionInfo::destroy(). Use destructor instead.
> 
> BUG=582717
> TEST=PaintLayerTest.ReflectionLeak
> 
> Committed: https://crrev.com/6137b72d44c0391a39e2a8f9cad9efb4706880e9
> Cr-Commit-Position: refs/heads/master@{#374556}

TBR=pdr@chromium.org,chrishtr@chromium.org,rnk@chromium.org,hans@chromium.org...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582717
==========

[commit-bot: I haz the power, 2016-02-10 10:10:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-10 10:11:20]

Description was changed from

==========
Revert of Reland Fix leak PaintLayerReflectionInfo (patchset #2 id:20001 of
https://codereview.chromium.org/1681663003/ )

Reason for revert:
I suspect this broke webkit_unit_tests on Mac Asan
(https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...).
Will reland if not the culprit.

Failure snippet:

[ RUN      ] All/ParameterizedWebFrameTest.CompositedSelectionBoundsCleared/1
=================================================================
==37555==ERROR: AddressSanitizer: heap-use-after-free on address 0x610000001b50
at pc 0x00010b1599b5 bp 0x7fff5bb669d0 sp 0x7fff5bb669c8
READ of size 8 at 0x610000001b50 thread T0
    #0 0x10b1599b4 in blink::PaintLayerScrollableArea::scrollbarsCanBeActive()
const (in webkit_unit_tests) + 420
    #1 0x105dd885b in blink::ScrollAnimatorMac::updateScrollerStyle() (in
webkit_unit_tests) + 283



Original issue's description:
> Reland Fix leak PaintLayerReflectionInfo
> 
> NOT FOR COMMIT, YET
> 
> Originally https://codereview.chromium.org/1657883002/
> Patch by wangxianzhu@
> 
> Previously PaintLayerReflectionInfo required destroy() to be called
> before destruction, but we missed the call in
> PaintLayer::updateReflectionInfo(), causing leak of the reflection
> layout object and the layer for the reflection.
> 
> Delete PaintLayerReflectionInfo::destroy(). Use destructor instead.
> 
> BUG=582717
> TEST=PaintLayerTest.ReflectionLeak
> 
> Committed: https://crrev.com/6137b72d44c0391a39e2a8f9cad9efb4706880e9
> Cr-Commit-Position: refs/heads/master@{#374556}

TBR=pdr@chromium.org,chrishtr@chromium.org,rnk@chromium.org,hans@chromium.org...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582717
==========

to

==========
Revert of Reland Fix leak PaintLayerReflectionInfo (patchset #2 id:20001 of
https://codereview.chromium.org/1681663003/ )

Reason for revert:
I suspect this broke webkit_unit_tests on Mac Asan
(https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...).
Will reland if not the culprit.

Failure snippet:

[ RUN      ] All/ParameterizedWebFrameTest.CompositedSelectionBoundsCleared/1
=================================================================
==37555==ERROR: AddressSanitizer: heap-use-after-free on address 0x610000001b50
at pc 0x00010b1599b5 bp 0x7fff5bb669d0 sp 0x7fff5bb669c8
READ of size 8 at 0x610000001b50 thread T0
    #0 0x10b1599b4 in blink::PaintLayerScrollableArea::scrollbarsCanBeActive()
const (in webkit_unit_tests) + 420
    #1 0x105dd885b in blink::ScrollAnimatorMac::updateScrollerStyle() (in
webkit_unit_tests) + 283

Original issue's description:
> Reland Fix leak PaintLayerReflectionInfo
>
> NOT FOR COMMIT, YET
>
> Originally https://codereview.chromium.org/1657883002/
> Patch by wangxianzhu@
>
> Previously PaintLayerReflectionInfo required destroy() to be called
> before destruction, but we missed the call in
> PaintLayer::updateReflectionInfo(), causing leak of the reflection
> layout object and the layer for the reflection.
>
> Delete PaintLayerReflectionInfo::destroy(). Use destructor instead.
>
> BUG=582717
> TEST=PaintLayerTest.ReflectionLeak
>
> Committed: https://crrev.com/6137b72d44c0391a39e2a8f9cad9efb4706880e9
> Cr-Commit-Position: refs/heads/master@{#374556}

TBR=pdr@chromium.org,chrishtr@chromium.org,rnk@chromium.org,hans@chromium.org...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582717

Committed: https://crrev.com/e0094729c3804d4b4c8a28d81148def71d4e4e40
Cr-Commit-Position: refs/heads/master@{#374633}
==========

[commit-bot: I haz the power, 2016-02-10 10:11:22]

Patchset 1 (id:??) landed as
https://crrev.com/e0094729c3804d4b4c8a28d81148def71d4e4e40
Cr-Commit-Position: refs/heads/master@{#374633}