Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1685073002: Revert of Reland Fix leak PaintLayerReflectionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index a98310828cb09afd4479028307d8094d59039827..895daeef48f0d1fa51a5d3e6030c529f6ee116a5 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -204,6 +204,9 @@
clearCompositedLayerMapping(true);
+ if (PaintLayerReflectionInfo* reflectionInfo = this->reflectionInfo())
+ reflectionInfo->destroy();
+
if (m_scrollableArea)
m_scrollableArea->dispose();
}
@@ -1423,6 +1426,7 @@
ensureRareData().reflectionInfo = adoptPtr(new PaintLayerReflectionInfo(*layoutBox()));
m_rareData->reflectionInfo->updateAfterStyleChange(oldStyle);
} else if (m_rareData && m_rareData->reflectionInfo) {
+ m_rareData->reflectionInfo->destroy();
m_rareData->reflectionInfo = nullptr;
}
}
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.h ('k') | third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698