Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1685063002: Make 'mode' required parameter for Element.attachShadow (Closed)

Created:
4 years, 10 months ago by kochi
Modified:
4 years, 10 months ago
Reviewers:
hayato
CC:
chromium-reviews, blink-reviews-w3ctests_chromium.org, webcomponents-bugzilla_chromium.org, tfarina, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make 'mode' required parameter for Element.attachShadow As 'mode' is a required parameter in the spec, omission should throw an exception. BUG=531990 TEST=imported/web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt Committed: https://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d Cr-Commit-Position: refs/heads/master@{#374628}

Patch Set 1 #

Patch Set 2 : more fixes for tests #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -136 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host2.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host3.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html View 1 1 chunk +0 lines, -89 lines 4 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4-expected.txt View 1 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host5.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/focus-method-with-delegatesFocus.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/focus-shadowhost-display-none.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/focus-slide-on-shadow-host.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/focus-with-dom-mutation.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRootInit.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685063002/40001
4 years, 10 months ago (2016-02-10 06:56:31 UTC) #3
kochi
PTAL https://codereview.chromium.org/1685063002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html File third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html (left): https://codereview.chromium.org/1685063002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html#oldcode1 third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html:1: <!DOCTYPE html> Deleted this file as multiple shadow ...
4 years, 10 months ago (2016-02-10 06:57:27 UTC) #5
hayato
https://codereview.chromium.org/1685063002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html File third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html (left): https://codereview.chromium.org/1685063002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html#oldcode1 third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html:1: <!DOCTYPE html> On 2016/02/10 06:57:27, kochi wrote: > Deleted ...
4 years, 10 months ago (2016-02-10 07:06:21 UTC) #6
kochi
https://codereview.chromium.org/1685063002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html File third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html (left): https://codereview.chromium.org/1685063002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html#oldcode1 third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html:1: <!DOCTYPE html> On 2016/02/10 07:06:21, hayato wrote: > On ...
4 years, 10 months ago (2016-02-10 07:09:48 UTC) #7
hayato
lgtm https://codereview.chromium.org/1685063002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html File third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html (left): https://codereview.chromium.org/1685063002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html#oldcode1 third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html:1: <!DOCTYPE html> On 2016/02/10 07:09:48, kochi wrote: > ...
4 years, 10 months ago (2016-02-10 08:07:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685063002/40001
4 years, 10 months ago (2016-02-10 08:15:22 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-10 08:19:33 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 08:20:55 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cc5607e9bd52a8720bf7c9c25eb2239da8f83a8d
Cr-Commit-Position: refs/heads/master@{#374628}

Powered by Google App Engine
This is Rietveld 408576698