third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html - Issue 1685063002: Make 'mode' required parameter for Element.attachShadow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html

Issue 1685063002: Make 'mode' required parameter for Element.attachShadow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more fixes for tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host4.html ('K') | « third_party/WebKit/LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host5.html ('k') | third_party/WebKit/LayoutTests/fast/dom/shadow/focus-method-with-delegatesFocus.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html b/third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html

index 704553ea35be33e4cd4a105668cf65bf15bcf769..9a2413de9435c6b057f1df9a4bcd52577bc04471 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/delegatesFocus-highlight-sibling.html

@@ -45,7 +45,7 @@ function RegisterXMenu() {

var xMenuProto = Object.create(HTMLElement.prototype);

xMenuProto.createdCallback = function() {

var delegatesFocus = this.hasAttribute('delegatesFocus');

- this.attachShadow({ 'delegatesFocus': delegatesFocus })

+ this.attachShadow({ 'mode': 'open', 'delegatesFocus': delegatesFocus })

.appendChild(

document.importNode(template.content, true)

);