Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag.

Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag.

It is on by default on Linux, Windows and ChromeOS. To bring the feature
up on Mac we are trying the already-written toolkit-views UI rather than
Cocoa. Currently it's working on Mac behind --enable-simplified-fullscreen-ui
but since this is the first time we are running toolkit-views UI by-default
on Mac, we want to bring it up via an experiment.

BUG=586304
Committed: https://crrev.com/a68ddbf069fae1f348b8038f65dd424f8bc92e93
Cr-Commit-Position: refs/heads/master@{#375048}

[tapted, 2016-02-11 08:49:39]

tapted@chromium.org changed reviewers:
+ asvitkine@chromium.org, scheib@chromium.org

[tapted, 2016-02-11 08:49:39]

Hi Vince and Alexei - please take a look. (I think I'm doing this right)

The finch change is in cl/114291338 but I'm not sure what order these should
land in (also I'm still total a google3/critique n00b).

Thanks!

[Alexei Svitkine (slow), 2016-02-11 16:13:28]

lgtm

[Alexei Svitkine (slow), 2016-02-11 16:14:16]

In terms of order of this change vs. the server-side change - there's no danger
in this case in landing server side change earlier - but obviously it will have
no effect until clients have the client-side changes to actually do something
based on it.

[scheib, 2016-02-11 17:08:58]

LGTM - but it's the first time I've seen use of the feautre_list. BTW, the bug
linked seems too broad -- there should probably be one specifically for enabling
on mac views.

[tapted, 2016-02-11 22:52:39]

Description was changed from

==========
Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag.

It is on by default on Linux, Windows and ChromeOS. To bring the feature
up on Mac we are trying the already-written toolkit-views UI rather than
Cocoa. Currently it's working on Mac behind --enable-simplified-fullscreen-ui
but since this is the first time we are running toolkit-views UI by-default
on Mac, we want to bring it up via an experiment.

BUG=585009
==========

to

==========
Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag.

It is on by default on Linux, Windows and ChromeOS. To bring the feature
up on Mac we are trying the already-written toolkit-views UI rather than
Cocoa. Currently it's working on Mac behind --enable-simplified-fullscreen-ui
but since this is the first time we are running toolkit-views UI by-default
on Mac, we want to bring it up via an experiment.

BUG=586304
==========

[tapted, 2016-02-11 22:58:19]

Thanks!

On 2016/02/11 17:08:58, scheib wrote:
> LGTM - but it's the first time I've seen use of the feautre_list. BTW, the bug
> linked seems too broad -- there should probably be one specifically for
enabling
> on mac views.

I've made http://crbug.com/586304 to track the Mac-specific Eng work required. I
had http://crbug.com/585009 which is mac-views-specific, but it's a restricted
launch bug, so it should be neater this way. I've also linked a more detailed
design doc we have specific to the mac views stuff at
http://crbug.com/585009#c2. (for non-mac platforms, there is Launch=
http://crbug.com/585002 Eng= http://crbug.com/352425 but that Eng bug is epic).

[tapted, 2016-02-11 22:58:48]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-02-11 22:59:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685043002/20001

[commit-bot: I haz the power, 2016-02-11 23:58:21]

Description was changed from

==========
Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag.

It is on by default on Linux, Windows and ChromeOS. To bring the feature
up on Mac we are trying the already-written toolkit-views UI rather than
Cocoa. Currently it's working on Mac behind --enable-simplified-fullscreen-ui
but since this is the first time we are running toolkit-views UI by-default
on Mac, we want to bring it up via an experiment.

BUG=586304
==========

to

==========
Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag.

It is on by default on Linux, Windows and ChromeOS. To bring the feature
up on Mac we are trying the already-written toolkit-views UI rather than
Cocoa. Currently it's working on Mac behind --enable-simplified-fullscreen-ui
but since this is the first time we are running toolkit-views UI by-default
on Mac, we want to bring it up via an experiment.

BUG=586304
==========

[commit-bot: I haz the power, 2016-02-11 23:58:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:39:42]

Description was changed from

==========
Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag.

It is on by default on Linux, Windows and ChromeOS. To bring the feature
up on Mac we are trying the already-written toolkit-views UI rather than
Cocoa. Currently it's working on Mac behind --enable-simplified-fullscreen-ui
but since this is the first time we are running toolkit-views UI by-default
on Mac, we want to bring it up via an experiment.

BUG=586304
==========

to

==========
Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag.

It is on by default on Linux, Windows and ChromeOS. To bring the feature
up on Mac we are trying the already-written toolkit-views UI rather than
Cocoa. Currently it's working on Mac behind --enable-simplified-fullscreen-ui
but since this is the first time we are running toolkit-views UI by-default
on Mac, we want to bring it up via an experiment.

BUG=586304

Committed: https://crrev.com/a68ddbf069fae1f348b8038f65dd424f8bc92e93
Cr-Commit-Position: refs/heads/master@{#375048}
==========

[commit-bot: I haz the power, 2016-02-16 22:39:42]

Patchset 2 (id:??) landed as
https://crrev.com/a68ddbf069fae1f348b8038f65dd424f8bc92e93
Cr-Commit-Position: refs/heads/master@{#375048}