Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: chrome/browser/ui/exclusive_access/exclusive_access_manager.cc

Issue 1685043002: Convert --{enable,disable}-simplified-fullscreen-ui to a feature flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h" 5 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "chrome/browser/app_mode/app_mode_utils.h" 9 #include "chrome/browser/app_mode/app_mode_utils.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_window.h" 11 #include "chrome/browser/ui/browser_window.h"
12 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h" 12 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
13 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h" 13 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
14 #include "chrome/browser/ui/exclusive_access/mouse_lock_controller.h" 14 #include "chrome/browser/ui/exclusive_access/mouse_lock_controller.h"
15 #include "chrome/common/chrome_switches.h" 15 #include "chrome/common/chrome_switches.h"
16 #include "content/public/browser/native_web_keyboard_event.h" 16 #include "content/public/browser/native_web_keyboard_event.h"
17 #include "ui/events/keycodes/keyboard_codes.h" 17 #include "ui/events/keycodes/keyboard_codes.h"
18 18
19 using content::WebContents; 19 using content::WebContents;
20 20
21 const base::Feature ExclusiveAccessManager::kSimplifiedUIFeature = {
22 "ViewsSimplifiedFullscreenUI",
23 #if defined(USE_AURA)
24 base::FEATURE_ENABLED_BY_DEFAULT,
25 #else
26 base::FEATURE_DISABLED_BY_DEFAULT,
27 #endif
28 };
29
21 ExclusiveAccessManager::ExclusiveAccessManager( 30 ExclusiveAccessManager::ExclusiveAccessManager(
22 ExclusiveAccessContext* exclusive_access_context) 31 ExclusiveAccessContext* exclusive_access_context)
23 : exclusive_access_context_(exclusive_access_context), 32 : exclusive_access_context_(exclusive_access_context),
24 fullscreen_controller_(this), 33 fullscreen_controller_(this),
25 mouse_lock_controller_(this) { 34 mouse_lock_controller_(this) {
26 } 35 }
27 36
28 ExclusiveAccessManager::~ExclusiveAccessManager() { 37 ExclusiveAccessManager::~ExclusiveAccessManager() {
29 } 38 }
30 39
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 93
85 GURL ExclusiveAccessManager::GetExclusiveAccessBubbleURL() const { 94 GURL ExclusiveAccessManager::GetExclusiveAccessBubbleURL() const {
86 GURL result = fullscreen_controller_.GetURLForExclusiveAccessBubble(); 95 GURL result = fullscreen_controller_.GetURLForExclusiveAccessBubble();
87 if (!result.is_valid()) 96 if (!result.is_valid())
88 result = mouse_lock_controller_.GetURLForExclusiveAccessBubble(); 97 result = mouse_lock_controller_.GetURLForExclusiveAccessBubble();
89 return result; 98 return result;
90 } 99 }
91 100
92 // static 101 // static
93 bool ExclusiveAccessManager::IsSimplifiedFullscreenUIEnabled() { 102 bool ExclusiveAccessManager::IsSimplifiedFullscreenUIEnabled() {
94 if (base::CommandLine::ForCurrentProcess()->HasSwitch( 103 return base::FeatureList::IsEnabled(kSimplifiedUIFeature);
95 switches::kEnableSimplifiedFullscreenUI)) {
96 return true;
97 }
98
99 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
100 switches::kDisableSimplifiedFullscreenUI)) {
101 return false;
102 }
103
104 // Enabled by default on Aura platforms only.
105 #if defined(USE_AURA)
106 return true;
107 #else
108 return false;
109 #endif // defined(USE_AURA)
110 } 104 }
111 105
112 void ExclusiveAccessManager::OnTabDeactivated(WebContents* web_contents) { 106 void ExclusiveAccessManager::OnTabDeactivated(WebContents* web_contents) {
113 fullscreen_controller_.OnTabDeactivated(web_contents); 107 fullscreen_controller_.OnTabDeactivated(web_contents);
114 mouse_lock_controller_.OnTabDeactivated(web_contents); 108 mouse_lock_controller_.OnTabDeactivated(web_contents);
115 } 109 }
116 110
117 void ExclusiveAccessManager::OnTabDetachedFromView(WebContents* web_contents) { 111 void ExclusiveAccessManager::OnTabDetachedFromView(WebContents* web_contents) {
118 fullscreen_controller_.OnTabDetachedFromView(web_contents); 112 fullscreen_controller_.OnTabDetachedFromView(web_contents);
119 mouse_lock_controller_.OnTabDetachedFromView(web_contents); 113 mouse_lock_controller_.OnTabDetachedFromView(web_contents);
(...skipping 29 matching lines...) Expand all
149 bool updateBubble = mouse_lock_controller_.OnDenyExclusiveAccessPermission(); 143 bool updateBubble = mouse_lock_controller_.OnDenyExclusiveAccessPermission();
150 updateBubble |= fullscreen_controller_.OnDenyExclusiveAccessPermission(); 144 updateBubble |= fullscreen_controller_.OnDenyExclusiveAccessPermission();
151 if (updateBubble) 145 if (updateBubble)
152 UpdateExclusiveAccessExitBubbleContent(); 146 UpdateExclusiveAccessExitBubbleContent();
153 } 147 }
154 148
155 void ExclusiveAccessManager::ExitExclusiveAccess() { 149 void ExclusiveAccessManager::ExitExclusiveAccess() {
156 fullscreen_controller_.ExitExclusiveAccessToPreviousState(); 150 fullscreen_controller_.ExitExclusiveAccessToPreviousState();
157 mouse_lock_controller_.LostMouseLock(); 151 mouse_lock_controller_.LostMouseLock();
158 } 152 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/exclusive_access/exclusive_access_manager.h ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698