Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1684903003:
UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags (Closed)
|
Created:
4 years, 10 months ago by loyso (OOO) Modified:
4 years, 10 months ago CC:
asvitkine+watch_chromium.org, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags
This will help us to determine a scope of the bug in ChromeOS.
BUG=585979
BUG=574859
Committed: https://crrev.com/4345c8eac93d86dcbff3ee95f66521ef94ff5d28
Cr-Commit-Position: refs/heads/master@{#374860}
Patch Set 1 #Patch Set 2 : Do not format. #Patch Set 3 : Rebase. #Patch Set 4 : Rebase. #Patch Set 5 : Rebase. #Patch Set 6 : Exclude OS Android. #Patch Set 7 : Rebase. #
Messages
Total messages: 34 (17 generated)
loyso@chromium.org changed reviewers: + isherman@chromium.org, jochen@chromium.org, thakis@chromium.org
Description was changed from ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags BUG=574859 ========== to ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags BUG=574859 ==========
loyso@chromium.org changed reviewers: + chrishtr@chromium.org, jam@chromium.org, mpearson@chromium.org - jochen@chromium.org
PTAL, anyone? This very simple and quite urgent.
Description was changed from ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags BUG=574859 ========== to ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to isolate a scope of the bug in ChromeOS. BUG=574859 ==========
I don't have owners for these files, unfortunately.
histograms.xml lgtm FYI your trybots are all red --mark
loyso@chromium.org changed reviewers: - chrishtr@chromium.org
loyso@chromium.org changed reviewers: - isherman@chromium.org
loyso@chromium.org changed reviewers: + sky@chromium.org
On 2016/02/10 00:09:28, Mark P (out Feb 5-8) wrote: > histograms.xml lgtm > FYI your trybots are all red Rebase was needed. chrome/ owners, PTAL!
Description was changed from ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to isolate a scope of the bug in ChromeOS. BUG=574859 ========== to ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to determine a scope of the bug in ChromeOS. BUG=574859 ==========
jam@chromium.org changed reviewers: - jam@chromium.org
On 2016/02/10 00:16:45, loyso wrote: > On 2016/02/10 00:09:28, Mark P (out Feb 5-8) wrote: > > histograms.xml lgtm > > FYI your trybots are all red > Rebase was needed. > > chrome/ owners, PTAL! removing myself since you already got an owner
loyso@chromium.org changed reviewers: + thestig@chromium.org
PTAL, chrome owners! Anyone?
Did you want this to be ChromeOS only?
On 2016/02/10 22:51:49, Lei Zhang wrote: > Did you want this to be ChromeOS only? No, we need this for all the desktops.
On 2016/02/10 22:55:08, loyso wrote: > On 2016/02/10 22:51:49, Lei Zhang wrote: > > Did you want this to be ChromeOS only? > No, we need this for all the desktops. Add !defined(OS_ANDROID) / <if expr="not is_android> then? Otherwise lgtm.
Description was changed from ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to determine a scope of the bug in ChromeOS. BUG=574859 ========== to ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to determine a scope of the bug in ChromeOS. BUG=585979 BUG=574859 ==========
On 2016/02/10 23:01:17, Lei Zhang wrote: > On 2016/02/10 22:55:08, loyso wrote: > > On 2016/02/10 22:51:49, Lei Zhang wrote: > > > Did you want this to be ChromeOS only? > > No, we need this for all the desktops. > > Add !defined(OS_ANDROID) / <if expr="not is_android> then? I thought kOsDesktop is enough. Fixing.
On 2016/02/10 23:01:17, Lei Zhang wrote: > Add !defined(OS_ANDROID) / <if expr="not is_android> then? Done.
The CQ bit was checked by loyso@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mpearson@chromium.org, thestig@chromium.org Link to the patchset: https://codereview.chromium.org/1684903003/#ps120001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684903003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684903003/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by loyso@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684903003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684903003/120001
Message was sent while issue was closed.
Description was changed from ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to determine a scope of the bug in ChromeOS. BUG=585979 BUG=574859 ========== to ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to determine a scope of the bug in ChromeOS. BUG=585979 BUG=574859 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to determine a scope of the bug in ChromeOS. BUG=585979 BUG=574859 ========== to ========== UI Compositor: Expose ui-disable-compositor-animation-timelines in about/flags This will help us to determine a scope of the bug in ChromeOS. BUG=585979 BUG=574859 Committed: https://crrev.com/4345c8eac93d86dcbff3ee95f66521ef94ff5d28 Cr-Commit-Position: refs/heads/master@{#374860} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/4345c8eac93d86dcbff3ee95f66521ef94ff5d28 Cr-Commit-Position: refs/heads/master@{#374860} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
