Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1684883002: [NaCl SDK] Remove old/unused gyp defines (Closed)

Created:
4 years, 10 months ago by Sam Clegg
Modified:
4 years, 10 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@irt_with_clang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove old/unused gyp defines - use_nacl_clang is now the default and has no meaning. - ninja is the default generator for gyp_chromeium and gyp_nacl. - support for nacl_allow_thin_archives was reverted from NaCl - Made GypNinjaBuild_Pnacl and GypNinjaBuild_PPAPI consistent. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk BUG= Committed: https://crrev.com/a0bbcbad97cffb9121dc42769c18150a0f032e0e Cr-Commit-Position: refs/heads/master@{#374694}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M native_client_sdk/src/build_tools/build_artifacts.py View 1 2 chunks +1 line, -4 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 3 chunks +4 lines, -6 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/build_artifacts_test.py View 1 2 7 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684883002/1
4 years, 10 months ago (2016-02-09 23:15:41 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684883002/20001
4 years, 10 months ago (2016-02-09 23:22:42 UTC) #7
Sam Clegg
4 years, 10 months ago (2016-02-09 23:32:34 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_nacl_sdk on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_nacl_sdk/builds/724)
4 years, 10 months ago (2016-02-09 23:48:53 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684883002/40001
4 years, 10 months ago (2016-02-09 23:59:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684883002/40001
4 years, 10 months ago (2016-02-10 02:36:09 UTC) #16
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-02-10 02:36:10 UTC) #18
binji
lgtm
4 years, 10 months ago (2016-02-10 18:44:37 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684883002/40001
4 years, 10 months ago (2016-02-10 18:51:33 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-10 19:00:58 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 19:01:50 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0bbcbad97cffb9121dc42769c18150a0f032e0e
Cr-Commit-Position: refs/heads/master@{#374694}

Powered by Google App Engine
This is Rietveld 408576698