Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 1684883002: [NaCl SDK] Remove old/unused gyp defines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@irt_with_clang
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/build_sdk.py
diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py
index 660c1bc117998c7248d2b8a61d1bdc5ace7de649..1ab95596672f4221c643da4a14e8a2444cba7db8 100755
--- a/native_client_sdk/src/build_tools/build_sdk.py
+++ b/native_client_sdk/src/build_tools/build_sdk.py
@@ -459,7 +459,7 @@ def GypNinjaBuild_PPAPI(arch, rel_out_dir):
GypNinjaBuild(arch, gyp_py, gyp_file, 'ppapi_lib', out_dir)
-def GypNinjaBuild_Pnacl(rel_out_dir, target_arch):
+def GypNinjaBuild_Pnacl(arch, rel_out_dir):
# TODO(binji): This will build the pnacl_irt_shim twice; once as part of the
# Chromium build, and once here. When we move more of the SDK build process
# to gyp, we can remove this.
@@ -468,14 +468,12 @@ def GypNinjaBuild_Pnacl(rel_out_dir, target_arch):
out_dir = MakeNinjaRelPath(rel_out_dir)
gyp_file = os.path.join(SRC_DIR, 'ppapi', 'native_client', 'src',
'untrusted', 'pnacl_irt_shim', 'pnacl_irt_shim.gyp')
- targets = ['aot']
- GypNinjaBuild(target_arch, gyp_py, gyp_file, targets, out_dir)
+ GypNinjaBuild(arch, gyp_py, gyp_file, 'aot', out_dir)
def GypNinjaBuild(arch, gyp_py_script, gyp_file, targets, out_dir):
gyp_env = dict(os.environ)
- gyp_env['GYP_GENERATORS'] = 'ninja'
- gyp_defines = ['nacl_allow_thin_archives=0', 'use_nacl_clang=1']
+ gyp_defines = []
if options.mac_sdk:
gyp_defines.append('mac_sdk=%s' % options.mac_sdk)
@@ -535,7 +533,7 @@ def BuildStepBuildToolchains(pepperdir, toolchains, build, clean):
for arch in ('ia32', 'arm'):
# Fill in the latest native pnacl shim library from the chrome build.
build_dir = GYPBUILD_DIR + '-pnacl-' + arch
- GypNinjaBuild_Pnacl(build_dir, arch)
+ GypNinjaBuild_Pnacl(arch, build_dir)
GypNinjaInstall(pepperdir, toolchains)
« no previous file with comments | « native_client_sdk/src/build_tools/build_artifacts.py ('k') | native_client_sdk/src/build_tools/tests/build_artifacts_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698