Issue 1684853003: WIP: allow to play Youtube if use_proprieraty_codecs=1 and ffmpeg_branding=Chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1684853003: WIP: allow to play Youtube if use_proprieraty_codecs=1 and ffmpeg_branding=Chromium (Closed)

Created:
4 years, 10 months ago by Julien Isorce Samsung

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

WIP: allow to play Youtube if use_proprieraty_codecs=1 and ffmpeg_branding=Chromium By checking at runtime if ffmpeg actually supports the requested codec. BUG=571417

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -20 lines)			Patch
M	build/common.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/video_decoder_shim.cc	View	3 chunks	+2 lines, -18 lines	0 comments	Download
M	media/base/media.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	media/base/media.cc	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	media/base/mime_util.cc	View	5 chunks	+99 lines, -1 line	0 comments	Download
M	media/base/mime_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Julien Isorce Samsung

4 years, 4 months ago (2016-08-18 20:50:58 UTC) #1

Description was changed from

==========
WIP: allow to play Youtube if use_proprieraty_codecs=1 and
ffmpeg_branding=Chromium

By checking at runtime if ffmpeg actually supports the requested codec.

BUG=571417
==========

to

==========
WIP: allow to play Youtube if use_proprieraty_codecs=1 and
ffmpeg_branding=Chromium

By checking at runtime if ffmpeg actually supports the requested codec.

BUG=571417
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages