Issue 168483002: Add a second-order Dictionary::convert() function template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 168483002: Add a second-order Dictionary::convert() function template. (Closed)

Created:
6 years, 10 months ago by sof

Modified:
6 years, 10 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add a second-order Dictionary::convert() function template. Avoid source code duplication of convert() method bodies for the parameterized pointer types. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167271

Patch Set 1 #

Patch Set 2 : Rename template argument #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -24 lines)			Patch
	M	Source/bindings/v8/Dictionary.h	View	1	2 chunks	+3 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sof

When you have a moment, please take a look. As requested in https://codereview.chromium.org/139803012/diff/130001/Source/bindings/v8/Dictionary.h#newcode326 , avoid ...

6 years, 10 months ago (2014-02-16 19:41:38 UTC) #1

haraken

LGTM (The side-by-side diff is broken.) F => PointerType

6 years, 10 months ago (2014-02-17 00:53:02 UTC) #2

sof

On 2014/02/17 00:53:02, haraken wrote: > LGTM (The side-by-side diff is broken.) > > F ...

6 years, 10 months ago (2014-02-17 06:20:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/168483002/90001

6 years, 10 months ago (2014-02-17 06:20:29 UTC) #5

Message was sent while issue was closed.

Change committed as 167271

Expand Messages | Collapse Messages