Move speech module over to Oilpan.

Source/bindings/v8/Dictionary.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 70 matching lines @@
     bool get(const String&, unsigned long long&) const;
     bool get(const String&, RefPtr<DOMWindow>&) const;
     bool get(const String&, RefPtr<Storage>&) const;
     bool get(const String&, MessagePortArray&) const;
     bool get(const String&, RefPtr<Uint8Array>&) const;
     bool get(const String&, RefPtr<ArrayBufferView>&) const;
     bool get(const String&, RefPtr<MIDIPort>&) const;
     bool get(const String&, RefPtr<MediaKeyError>&) const;
     bool get(const String&, RefPtr<TrackBase>&) const;
     bool get(const String&, RefPtr<SpeechRecognitionError>&) const;
-    bool get(const String&, RefPtr<SpeechRecognitionResult>&) const;
-    bool get(const String&, RefPtr<SpeechRecognitionResultList>&) const;
+    bool get(const String&, RefPtrWillBeRawPtr<SpeechRecognitionResult>&) const;
+    bool get(const String&, RefPtrWillBeRawPtr<SpeechRecognitionResultList>&) const;
     bool get(const String&, RefPtr<MediaStream>&) const;
     bool get(const String&, RefPtr<EventTarget>&) const;
     bool get(const String&, HashSet<AtomicString>&) const;
     bool get(const String&, Dictionary&) const;
     bool get(const String&, Vector<String>&) const;
     bool get(const String&, ArrayValue&) const;
     bool get(const String&, RefPtr<DOMError>&) const;
     bool get(const String&, OwnPtr<VoidCallback>&) const;
     bool get(const String&, v8::Local<v8::Value>&) const;
 
@@ skipping 51 matching lines @@
 
     template<typename IntegralType>
     bool convert(ConversionContext &, const String&, IntegralType&) const;
     bool convert(ConversionContext &, const String&, MessagePortArray&) const;
     bool convert(ConversionContext &, const String&, HashSet<AtomicString>&) const;
     bool convert(ConversionContext &, const String&, Dictionary&) const;
     bool convert(ConversionContext &, const String&, Vector<String>&) const;
     bool convert(ConversionContext &, const String&, ArrayValue&) const;
     template<typename T>
     bool convert(ConversionContext &, const String&, RefPtr<T>&) const;
+    template<typename T>
+    bool convert(ConversionContext &, const String&, RawPtr<T>&) const;

[haraken, 2014/02/12 05:18:45]

Nit: Unnecessary space before '&'.

[sof, 2014/02/12 07:48:51]

Well spotted, fixed.

 
     template<typename StringType>
     bool getStringType(const String&, StringType&) const;
 
     bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;
     bool getOwnPropertyNames(Vector<String>&) const;
 
     bool getWithUndefinedOrNullCheck(const String&, String&) const;
 
     bool hasProperty(const String&) const;
@@ skipping 140 matching lines @@
 
     v8::Local<v8::Value> v8Value;
     getKey(key, v8Value);
     if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value))
         return true;
 
     context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does not have a " + context.typeName() + " type."));
     return false;
 }
 
+template<typename T> bool Dictionary::convert(ConversionContext& context, const String& key, RawPtr<T>& value) const

[haraken, 2014/02/12 05:18:45]

Nit: It's a shame that we have to duplicate the convert method a lot of times.
We should templatize the convert methods at some point.

[sof, 2014/02/12 07:48:51]

Seems ripe for that; we can handle that separately.

+{
+    ConversionContextScope scope(context);
+
+    if (!get(key, value))
+        return true;
+
+    if (value)
+        return true;
+
+    v8::Local<v8::Value> v8Value;
+    getKey(key, v8Value);
+    if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value))
+        return true;
+
+    context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does not have a " + context.typeName() + " type."));
+    return false;
+}
+
 }
 
 #endif // Dictionary_h