Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: media/cast/logging/logging_defines.h

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/stack_frame.h ('k') | media/cast/net/pacing/paced_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/logging/logging_defines.h
diff --git a/media/cast/logging/logging_defines.h b/media/cast/logging/logging_defines.h
index 7d17507367345aa0c91bb9fa9925b111947db3f1..33ea72dc81b518e27346a2a09ef120662525e245 100644
--- a/media/cast/logging/logging_defines.h
+++ b/media/cast/logging/logging_defines.h
@@ -64,6 +64,8 @@ struct FrameEvent {
int height;
// Size of encoded frame in bytes. Only set for FRAME_ENCODED event.
+ // Note: we use uint32_t instead of size_t for byte count because this struct
+ // is sent over IPC which could span 32 & 64 bit processes.
uint32_t size;
// Time of event logged.
« no previous file with comments | « extensions/common/stack_frame.h ('k') | media/cast/net/pacing/paced_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698