Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: chrome/common/spellcheck_marker.h

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/task_manager.cc ('k') | components/autofill/core/common/form_field_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/spellcheck_marker.h
diff --git a/chrome/common/spellcheck_marker.h b/chrome/common/spellcheck_marker.h
index 4305c22f0efab67ff359e506f6e4e5f4f5a03a74..866ec03cb53cfb3212f811b7a355e446cf217e36 100644
--- a/chrome/common/spellcheck_marker.h
+++ b/chrome/common/spellcheck_marker.h
@@ -29,6 +29,9 @@ class SpellCheckMarker {
: hash(hash), offset(offset) {}
uint32_t hash;
+ // Note: we use uint32_t instead of size_t because this struct is sent over
+ // IPC which could span 32 & 64 bit processes. This is fine since the offset
+ // shouldn't exceed UINT32_MAX even on 64 bit builds.
uint32_t offset;
};
« no previous file with comments | « chrome/browser/task_manager/task_manager.cc ('k') | components/autofill/core/common/form_field_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698