Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Issue 1684733003: Editing: Pass failure information of CompositeEditCommand::deleteSelection() to TypingCommand::doAp… (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: Pass failure information of CompositeEditCommand::deleteSelection() to TypingCommand::doApply(). Passing EditingState through the following path in order to abort the command gracefully: - CompositeEditCommand::deleteSelection() - TypingCommand::deleteKeyPressed() - TypingCommand::doApply() This is necessary in the following case. It removes <body> from the document during Delete command. <iframe id=tCF5 src="javascript:onunload = function() { if (!top.container) { top.container = document.createElement('div'); top.container.appendChild(frameElement.parentNode); } }">M!?+Bvi9SO[ </iframe><script> document.designMode = 'on'; rr746 = document.createRange(); rr746.selectNodeContents(tCF5) window.getSelection().addRange(rr746); document.execCommand("Delete") </script> BUG=570869 Committed: https://crrev.com/ac72a2a815cfd6f42518224671bddf7b5ac6e3f4 Cr-Commit-Position: refs/heads/master@{#374634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 6 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
yosin@, would you review this please?
4 years, 10 months ago (2016-02-10 08:53:19 UTC) #3
yosin_UTC9
lgtm
4 years, 10 months ago (2016-02-10 09:05:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684733003/1
4 years, 10 months ago (2016-02-10 09:17:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 10:18:35 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 10:19:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac72a2a815cfd6f42518224671bddf7b5ac6e3f4
Cr-Commit-Position: refs/heads/master@{#374634}

Powered by Google App Engine
This is Rietveld 408576698