Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 1684733003: Editing: Pass failure information of CompositeEditCommand::deleteSelection() to TypingCommand::doAp… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 // insert node before, after, or at split of tab span 589 // insert node before, after, or at split of tab span
590 insertNodeAt(node, positionOutsideTabSpan(pos)); 590 insertNodeAt(node, positionOutsideTabSpan(pos));
591 } 591 }
592 592
593 void CompositeEditCommand::deleteSelection(EditingState* editingState, bool smar tDelete, bool mergeBlocksAfterDelete, bool expandForSpecialElements, bool saniti zeMarkup) 593 void CompositeEditCommand::deleteSelection(EditingState* editingState, bool smar tDelete, bool mergeBlocksAfterDelete, bool expandForSpecialElements, bool saniti zeMarkup)
594 { 594 {
595 if (endingSelection().isRange()) 595 if (endingSelection().isRange())
596 applyCommandToComposite(DeleteSelectionCommand::create(document(), smart Delete, mergeBlocksAfterDelete, expandForSpecialElements, sanitizeMarkup), editi ngState); 596 applyCommandToComposite(DeleteSelectionCommand::create(document(), smart Delete, mergeBlocksAfterDelete, expandForSpecialElements, sanitizeMarkup), editi ngState);
597 } 597 }
598 598
599 void CompositeEditCommand::deleteSelection(const VisibleSelection &selection, bo ol smartDelete, bool mergeBlocksAfterDelete, bool expandForSpecialElements, bool sanitizeMarkup) 599 void CompositeEditCommand::deleteSelection(const VisibleSelection &selection, Ed itingState* editingState, bool smartDelete, bool mergeBlocksAfterDelete, bool ex pandForSpecialElements, bool sanitizeMarkup)
600 { 600 {
601 if (selection.isRange()) 601 if (selection.isRange())
602 applyCommandToComposite(DeleteSelectionCommand::create(selection, smartD elete, mergeBlocksAfterDelete, expandForSpecialElements, sanitizeMarkup)); 602 applyCommandToComposite(DeleteSelectionCommand::create(selection, smartD elete, mergeBlocksAfterDelete, expandForSpecialElements, sanitizeMarkup), editin gState);
603 } 603 }
604 604
605 void CompositeEditCommand::removeCSSProperty(PassRefPtrWillBeRawPtr<Element> ele ment, CSSPropertyID property) 605 void CompositeEditCommand::removeCSSProperty(PassRefPtrWillBeRawPtr<Element> ele ment, CSSPropertyID property)
606 { 606 {
607 applyCommandToComposite(RemoveCSSPropertyCommand::create(document(), element , property)); 607 applyCommandToComposite(RemoveCSSPropertyCommand::create(document(), element , property));
608 } 608 }
609 609
610 void CompositeEditCommand::removeElementAttribute(PassRefPtrWillBeRawPtr<Element > element, const QualifiedName& attribute) 610 void CompositeEditCommand::removeElementAttribute(PassRefPtrWillBeRawPtr<Element > element, const QualifiedName& attribute)
611 { 611 {
612 setNodeAttribute(element, attribute, AtomicString()); 612 setNodeAttribute(element, attribute, AtomicString());
(...skipping 915 matching lines...) Expand 10 before | Expand all | Expand 10 after
1528 } 1528 }
1529 1529
1530 DEFINE_TRACE(CompositeEditCommand) 1530 DEFINE_TRACE(CompositeEditCommand)
1531 { 1531 {
1532 visitor->trace(m_commands); 1532 visitor->trace(m_commands);
1533 visitor->trace(m_composition); 1533 visitor->trace(m_composition);
1534 EditCommand::trace(visitor); 1534 EditCommand::trace(visitor);
1535 } 1535 }
1536 1536
1537 } // namespace blink 1537 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698