Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1684313002: Make copySurface work for texture dsts, return a bool, & add unit test. (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : whitespace #

Total comments: 2

Patch Set 4 : remove unneeded memset #

Patch Set 5 : include <initializer_list> #

Patch Set 6 : fix uninit warning #

Patch Set 7 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -51 lines) Patch
M include/gpu/GrContext.h View 1 1 chunk +4 lines, -11 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 chunks +22 lines, -13 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 1 chunk +8 lines, -6 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.cpp View 1 2 chunks +7 lines, -12 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +2 lines, -1 line 0 comments Download
A tests/CopySurfaceTest.cpp View 1 2 3 4 5 1 chunk +163 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (17 generated)
bsalomon
4 years, 10 months ago (2016-02-11 16:37:48 UTC) #4
robertphillips
lgtm https://codereview.chromium.org/1684313002/diff/40001/tests/CopySurfaceTest.cpp File tests/CopySurfaceTest.cpp (right): https://codereview.chromium.org/1684313002/diff/40001/tests/CopySurfaceTest.cpp#newcode32 tests/CopySurfaceTest.cpp:32: SkAutoTMalloc<uint32_t> dstPixels(kW * kH); Is this memset useful ...
4 years, 10 months ago (2016-02-11 18:31:29 UTC) #5
bsalomon
https://codereview.chromium.org/1684313002/diff/40001/tests/CopySurfaceTest.cpp File tests/CopySurfaceTest.cpp (right): https://codereview.chromium.org/1684313002/diff/40001/tests/CopySurfaceTest.cpp#newcode32 tests/CopySurfaceTest.cpp:32: SkAutoTMalloc<uint32_t> dstPixels(kW * kH); On 2016/02/11 18:31:29, robertphillips wrote: ...
4 years, 10 months ago (2016-02-11 18:49:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684313002/60001
4 years, 10 months ago (2016-02-11 18:49:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/194)
4 years, 10 months ago (2016-02-11 18:50:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684313002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684313002/80001
4 years, 10 months ago (2016-02-11 19:01:13 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/6099)
4 years, 10 months ago (2016-02-11 19:02:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684313002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684313002/100001
4 years, 10 months ago (2016-02-11 19:07:58 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741
4 years, 10 months ago (2016-02-11 19:42:35 UTC) #22
kjlubick
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1690053002/ by kjlubick@google.com. ...
4 years, 10 months ago (2016-02-11 20:05:09 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684313002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684313002/120001
4 years, 10 months ago (2016-02-16 15:08:19 UTC) #27
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 15:34:20 UTC) #29
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/b8fea97a7a493897fcff33aa2932d875c572f163

Powered by Google App Engine
This is Rietveld 408576698