Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1684173002:
Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. (Closed)
|
Created:
4 years, 10 months ago by Stephen White Modified:
4 years, 10 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats.
BUG=585692, 585211
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/655530d81ebe07e4f52303b3863bf586f9d0cd4f
Cr-Commit-Position: refs/heads/master@{#374727}
Patch Set 1 #Patch Set 2 : Better fix from Mo #
Messages
Total messages: 27 (13 generated)
Description was changed from ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692 ========== to ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
senorblanco@chromium.org changed reviewers: + kbr@chromium.org, zmo@google.com
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684173002/1
I realize now I should probably not be hand-editing this file.
On 2016/02/10 17:13:06, Stephen White wrote: > I realize now I should probably not be hand-editing this file. Right, you need to edit the gpu/command_buffer/build_gles2_cmd_buffer.py But if this format is only added through an extension, then you will need to add it at run time in feature_info.cc
On 2016/02/10 17:17:15, Zhenyao Mo wrote: > On 2016/02/10 17:13:06, Stephen White wrote: > > I realize now I should probably not be hand-editing this file. > > Right, you need to edit the gpu/command_buffer/build_gles2_cmd_buffer.py > > But if this format is only added through an extension, then you will need to add > it at run time in feature_info.cc Note that the enums are already there in *autogen.h unconditionally, in valid_image_internal_format_table. Not sure if that's a bug.
On 2016/02/10 17:46:40, Stephen White wrote: > On 2016/02/10 17:17:15, Zhenyao Mo wrote: > > On 2016/02/10 17:13:06, Stephen White wrote: > > > I realize now I should probably not be hand-editing this file. > > > > Right, you need to edit the gpu/command_buffer/build_gles2_cmd_buffer.py > > > > But if this format is only added through an extension, then you will need to > add > > it at run time in feature_info.cc > > Note that the enums are already there in *autogen.h unconditionally, in > valid_image_internal_format_table. > > Not sure if that's a bug. It belongs to an extension Chrome always exposes, so I guess either way works.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
New patch up. PTAL.
lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684173002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zmo@chromium.org
Description was changed from ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692,585211 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684173002/20001
The CQ bit was unchecked by senorblanco@chromium.org
The CQ bit was checked by senorblanco@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684173002/20001
Message was sent while issue was closed.
Description was changed from ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692,585211 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692,585211 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692,585211 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add GL_RGB_YCBCR_422_CHROMIUM to the list of valid filterable formats. BUG=585692,585211 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/655530d81ebe07e4f52303b3863bf586f9d0cd4f Cr-Commit-Position: refs/heads/master@{#374727} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/655530d81ebe07e4f52303b3863bf586f9d0cd4f Cr-Commit-Position: refs/heads/master@{#374727} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
