Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 1684123003: Revert of Enable NV12 VideoFrames on Mac. (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, Zhenyao Mo, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable NV12 VideoFrames on Mac. (patchset #3 id:40001 of https://codereview.chromium.org/1686443002/ ) Reason for revert: Revert to see if the bot recovers. Original issue's description: > Enable NV12 VideoFrames on Mac. > > As described in crbug.com/524582, we observed a reduction in power > consumption when this format is used to display videos directly using > the WindowServer. > > The downside of this format is that a conversion from YUV to RGB will > be performed on the GPU using GL when the VideoFrame has to be used > from GL. > > BUG=524582 TBR=ccameron@chromium.org,dalecurtis@chromium.org,dcastagna@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524582 Committed: https://crrev.com/1bdd0d6692e0108814a014538a9209d35c5b8c80 Cr-Commit-Position: refs/heads/master@{#374847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Zhenyao Mo
Created Revert of Enable NV12 VideoFrames on Mac.
4 years, 10 months ago (2016-02-11 03:19:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684123003/1
4 years, 10 months ago (2016-02-11 03:20:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 03:21:50 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:34:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bdd0d6692e0108814a014538a9209d35c5b8c80
Cr-Commit-Position: refs/heads/master@{#374847}

Powered by Google App Engine
This is Rietveld 408576698