media/video/gpu_memory_buffer_video_frame_pool.cc - Issue 1684123003: Revert of Enable NV12 VideoFrames on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/gpu_memory_buffer_video_frame_pool.cc

Issue 1684123003: Revert of Enable NV12 VideoFrames on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/gpu_memory_buffer_video_frame_pool.cc

diff --git a/media/video/gpu_memory_buffer_video_frame_pool.cc b/media/video/gpu_memory_buffer_video_frame_pool.cc

index e7ffd99332be2d29bb1251968d80001562fbfc2f..7ac0cd763324765bc657812752e301031e5e0d7a 100644

--- a/media/video/gpu_memory_buffer_video_frame_pool.cc

+++ b/media/video/gpu_memory_buffer_video_frame_pool.cc

@@ -202,7 +202,8 @@

return GL_RED_EXT;

case PIXEL_FORMAT_NV12:

DCHECK_LE(plane, 1u);

- return GL_RGB_YCBCR_420V_CHROMIUM;

+ DLOG(WARNING) << "NV12 format not supported yet";

+ return 0; // TODO(andresantoso): Implement extension for NV12.

case PIXEL_FORMAT_UYVY:

DCHECK_EQ(0u, plane);

return GL_RGB_YCBCR_422_CHROMIUM;

« no previous file with comments | « content/renderer/media/renderer_gpu_video_accelerator_factories.cc ('k') | no next file » | no next file with comments »