Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 16841007: Add platform APIs for the unprefixed EME APIs. (Closed)

Created:
7 years, 6 months ago by ddorwin
Modified:
7 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Add platform APIs for the unprefixed EME APIs. BUG=224791 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152323

Patch Set 1 #

Total comments: 2

Patch Set 2 : return sessionId by value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
M public/platform/Platform.h View 2 chunks +8 lines, -0 lines 0 comments Download
A public/platform/WebContentDecryptionModule.h View 1 chunk +48 lines, -0 lines 0 comments Download
A public/platform/WebContentDecryptionModuleSession.h View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ddorwin
This is the final version of the platform APIs from https://codereview.chromium.org/16387015/. After I land this, ...
7 years, 6 months ago (2013-06-13 00:12:13 UTC) #1
abarth-chromium
https://codereview.chromium.org/16841007/diff/1/public/platform/WebContentDecryptionModuleSession.h File public/platform/WebContentDecryptionModuleSession.h (right): https://codereview.chromium.org/16841007/diff/1/public/platform/WebContentDecryptionModuleSession.h#newcode58 public/platform/WebContentDecryptionModuleSession.h:58: virtual const WebString& sessionId() const = 0; Are you ...
7 years, 6 months ago (2013-06-13 00:15:45 UTC) #2
abarth-chromium
LGTM
7 years, 6 months ago (2013-06-13 00:16:24 UTC) #3
ddorwin
https://codereview.chromium.org/16841007/diff/1/public/platform/WebContentDecryptionModuleSession.h File public/platform/WebContentDecryptionModuleSession.h (right): https://codereview.chromium.org/16841007/diff/1/public/platform/WebContentDecryptionModuleSession.h#newcode58 public/platform/WebContentDecryptionModuleSession.h:58: virtual const WebString& sessionId() const = 0; On 2013/06/13 ...
7 years, 6 months ago (2013-06-13 00:24:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/16841007/12001
7 years, 6 months ago (2013-06-13 00:30:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/16841007/12001
7 years, 6 months ago (2013-06-13 02:40:27 UTC) #6
ddorwin
7 years, 6 months ago (2013-06-13 05:27:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r152323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698