Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1683793004: [crankshaft] Disable Crankshaft when it sees a tail call. (Closed)

Created:
4 years, 10 months ago by Igor Sheludko
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Disable Crankshaft when it sees a tail call. This CL also removes tail call support made so far from Crankshaft. BUG=v8:4698 LOG=N Committed: https://crrev.com/e82588f647a3f38a73115b0c9f09a7041db2fe4b Cr-Commit-Position: refs/heads/master@{#33885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -71 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 7 chunks +9 lines, -12 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 3 chunks +4 lines, -11 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683793004/1
4 years, 10 months ago (2016-02-11 08:35:57 UTC) #2
Igor Sheludko
PTAL
4 years, 10 months ago (2016-02-11 08:36:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 09:08:44 UTC) #6
Benedikt Meurer
LGTM!
4 years, 10 months ago (2016-02-11 09:56:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683793004/1
4 years, 10 months ago (2016-02-11 09:57:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 09:58:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 09:58:55 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 10:41:17 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e82588f647a3f38a73115b0c9f09a7041db2fe4b
Cr-Commit-Position: refs/heads/master@{#33885}

Powered by Google App Engine
This is Rietveld 408576698