Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: src/crankshaft/hydrogen-instructions.h

Issue 1683793004: [crankshaft] Disable Crankshaft when it sees a tail call. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.h
diff --git a/src/crankshaft/hydrogen-instructions.h b/src/crankshaft/hydrogen-instructions.h
index 53e8b0f645006afddd10bcadb9b17679eb676742..e73dbb952da702b7aac8184d95967025feb98e35 100644
--- a/src/crankshaft/hydrogen-instructions.h
+++ b/src/crankshaft/hydrogen-instructions.h
@@ -2395,9 +2395,8 @@ class HInvokeFunction final : public HBinaryCall {
class HCallFunction final : public HBinaryCall {
public:
- DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P4(HCallFunction, HValue*, int,
- ConvertReceiverMode,
- TailCallMode);
+ DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P3(HCallFunction, HValue*, int,
+ ConvertReceiverMode);
HValue* context() const { return first(); }
HValue* function() const { return second(); }
@@ -2405,9 +2404,6 @@ class HCallFunction final : public HBinaryCall {
ConvertReceiverMode convert_mode() const {
return ConvertReceiverModeField::decode(bit_field_);
}
- TailCallMode tail_call_mode() const {
- return TailCallModeField::decode(bit_field_);
- }
FeedbackVectorSlot slot() const { return slot_; }
Handle<TypeFeedbackVector> feedback_vector() const {
return feedback_vector_;
@@ -2427,17 +2423,14 @@ class HCallFunction final : public HBinaryCall {
private:
HCallFunction(HValue* context, HValue* function, int argument_count,
- ConvertReceiverMode convert_mode, TailCallMode tail_call_mode)
+ ConvertReceiverMode convert_mode)
: HBinaryCall(context, function, argument_count),
- bit_field_(ConvertReceiverModeField::encode(convert_mode) |
- TailCallModeField::encode(tail_call_mode)) {}
+ bit_field_(ConvertReceiverModeField::encode(convert_mode)) {}
Handle<TypeFeedbackVector> feedback_vector_;
FeedbackVectorSlot slot_;
class ConvertReceiverModeField : public BitField<ConvertReceiverMode, 0, 2> {
};
- class TailCallModeField
- : public BitField<TailCallMode, ConvertReceiverModeField::kNext, 1> {};
uint32_t bit_field_;
};
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698