Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: base/BUILD.gn

Issue 1683793003: gn/win: Copy dbghelp.dll to the output dir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 3bafc89ff1939bffd03a1e487233f4fd31d63a55..7a6c73aae04873081db181cc306bc4f692e5210a 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -52,6 +52,15 @@ if (is_win) {
"/DELAYLOAD:setupapi.dll",
]
}
+
+ copy("copy_dbghelp.dll") {
+ sources = [
+ "../build/win/dbghelp_xp/dbghelp.dll",
+ ]
+ outputs = [
+ "$root_out_dir/{{source_file_part}}",
+ ]
+ }
}
if (is_nacl_nonsfi) {
@@ -1111,7 +1120,10 @@ component("base") {
# Required for base/stack_trace_win.cc to symbolize correctly.
data += [ "$root_build_dir/dbghelp.dll" ]
- deps += [ "//base/trace_event/etw_manifest:chrome_events_win" ]
+ deps += [
+ ":copy_dbghelp.dll",
+ "//base/trace_event/etw_manifest:chrome_events_win",
+ ]
if (is_component_build) {
# Copy the VS runtime DLLs into the isolate so that they don't have to be
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698