Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: base/BUILD.gn

Issue 1683793003: gn/win: Copy dbghelp.dll to the output dir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 if (is_win) { 45 if (is_win) {
46 # This is in a separate config so the flags can be applied to dependents. 46 # This is in a separate config so the flags can be applied to dependents.
47 # ldflags in GN aren't automatically inherited. 47 # ldflags in GN aren't automatically inherited.
48 config("base_win_linker_flags") { 48 config("base_win_linker_flags") {
49 ldflags = [ 49 ldflags = [
50 "/DELAYLOAD:cfgmgr32.dll", 50 "/DELAYLOAD:cfgmgr32.dll",
51 "/DELAYLOAD:powrprof.dll", 51 "/DELAYLOAD:powrprof.dll",
52 "/DELAYLOAD:setupapi.dll", 52 "/DELAYLOAD:setupapi.dll",
53 ] 53 ]
54 } 54 }
55
56 copy("copy_dbghelp.dll") {
57 sources = [
58 "../build/win/dbghelp_xp/dbghelp.dll",
59 ]
60 outputs = [
61 "$root_out_dir/{{source_file_part}}",
62 ]
63 }
55 } 64 }
56 65
57 if (is_nacl_nonsfi) { 66 if (is_nacl_nonsfi) {
58 # Must be in a config because of how GN orders flags (otherwise -Wall will 67 # Must be in a config because of how GN orders flags (otherwise -Wall will
59 # appear after this, and turn it back on). 68 # appear after this, and turn it back on).
60 config("nacl_nonsfi_warnings") { 69 config("nacl_nonsfi_warnings") {
61 # file_util_posix.cc contains a function which is not 70 # file_util_posix.cc contains a function which is not
62 # being used by nacl_helper_nonsfi. 71 # being used by nacl_helper_nonsfi.
63 cflags = [ "-Wno-unused-function" ] 72 cflags = [ "-Wno-unused-function" ]
64 } 73 }
(...skipping 1039 matching lines...) Expand 10 before | Expand all | Expand 10 after
1104 "strings/string16.cc", 1113 "strings/string16.cc",
1105 1114
1106 # Not using sha1_win.cc because it may have caused a 1115 # Not using sha1_win.cc because it may have caused a
1107 # regression to page cycler moz. 1116 # regression to page cycler moz.
1108 "sha1_win.cc", 1117 "sha1_win.cc",
1109 ] 1118 ]
1110 1119
1111 # Required for base/stack_trace_win.cc to symbolize correctly. 1120 # Required for base/stack_trace_win.cc to symbolize correctly.
1112 data += [ "$root_build_dir/dbghelp.dll" ] 1121 data += [ "$root_build_dir/dbghelp.dll" ]
1113 1122
1114 deps += [ "//base/trace_event/etw_manifest:chrome_events_win" ] 1123 deps += [
1124 ":copy_dbghelp.dll",
1125 "//base/trace_event/etw_manifest:chrome_events_win",
1126 ]
1115 1127
1116 if (is_component_build) { 1128 if (is_component_build) {
1117 # Copy the VS runtime DLLs into the isolate so that they don't have to be 1129 # Copy the VS runtime DLLs into the isolate so that they don't have to be
1118 # preinstalled on the target machine. The debug runtimes have a "d" at 1130 # preinstalled on the target machine. The debug runtimes have a "d" at
1119 # the end. 1131 # the end.
1120 if (is_debug) { 1132 if (is_debug) {
1121 vcrt_suffix = "d" 1133 vcrt_suffix = "d"
1122 } else { 1134 } else {
1123 vcrt_suffix = "" 1135 vcrt_suffix = ""
1124 } 1136 }
(...skipping 913 matching lines...) Expand 10 before | Expand all | Expand 10 after
2038 2050
2039 # GYP: //base.gyp:base_java_unittest_support 2051 # GYP: //base.gyp:base_java_unittest_support
2040 android_library("base_java_unittest_support") { 2052 android_library("base_java_unittest_support") {
2041 deps = [ 2053 deps = [
2042 ":base_java", 2054 ":base_java",
2043 ] 2055 ]
2044 java_files = 2056 java_files =
2045 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2057 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2046 } 2058 }
2047 } 2059 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698