Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1683693002: Revert of SkTArray to move when moving. (Closed)

Created:
4 years, 10 months ago by mtklein
Modified:
4 years, 10 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkTArray to move when moving. (patchset #3 id:40001 of https://codereview.chromium.org/1672063002/ ) Reason for revert: Broke the Chrome roll: https://codereview.chromium.org/1680563005 Original issue's description: > SkTArray to move when moving. > > This updates SkTArray to move elements when possible, instead of always > copying them. > > TBR=reed > Agreed moving is good. This should also become private. > > Committed: https://skia.googlesource.com/skia/+/3c69348e725131150e4ab962dec1b3ff1148a6bd TBR=reed@google.com,bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/4984b85037bf0733d848318dfaff03ab85204a6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -35 lines) Patch
M include/core/SkTArray.h View 8 chunks +50 lines, -34 lines 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of SkTArray to move when moving.
4 years, 10 months ago (2016-02-09 13:13:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683693002/1
4 years, 10 months ago (2016-02-09 13:14:00 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 13:14:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4984b85037bf0733d848318dfaff03ab85204a6f

Powered by Google App Engine
This is Rietveld 408576698