Roll src/third_party/skia/ 629f25a7e..81bb79b7b (23 commits).

Roll src/third_party/skia/ 629f25a7e..81bb79b7b (23 commits).

https://chromium.googlesource.com/skia.git/+log/629f25a7ef22..81bb79b7b979

$ git log 629f25a7e..81bb79b7b --date=short --no-merges --format='%ad %ae %s'
2016-02-08 mtklein Remove SkNx AVX code.  It is not really used.  Getting in the way of refactoring.
2016-02-08 scroggo Optionally run RAW images serially
2016-02-08 mtklein DM: this must have been missing from the previous CL
2016-02-08 joshualitt Skia serve now supports favicon correctly
2016-02-08 brianosman Support --dryRun in nanobench to get a list of benchmarks.
2016-02-08 msarett Optimize CMYK->RGBA (BGRA) transform for jpeg decodes
2016-02-08 reed extend modecolorfilter to 4f
2016-02-08 mtklein dm: simplify parallel/serial decisions
2016-02-08 sheyang Reland of whitespace change to test bugdroid (patchset #1 id:1 of https://codereview.chromium.org/1673083003/ )
2016-02-08 reed remove dead SK_SUPPORT_LEGACY_NEG_SCALE_HQ flag
2016-02-08 msarett Blacklist RAW images on GPU tests
2016-02-08 ethannicholas Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (patchset #2 id:20001 of https://codereview.chromium.org/1681643002/ )
2016-02-08 ethannicholas Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. SkJSONCanvas and SkJSONRenderer will be deleted once the debug server has been updated. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002
2016-02-08 kjlubick Reland of SkTArray to move when moving. (patchset #1 id:1 of https://codereview.chromium.org/1677103002/ )
2016-02-08 cdalton Improve GLSL integer support
2016-02-08 kjlubick Revert of SkTArray to move when moving. (patchset #3 id:40001 of https://codereview.chromium.org/1672063002/ )
2016-02-08 mtklein msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex
2016-02-08 halcanary SkDeflateWStream: support gzip output
2016-02-08 msarett Test CodecImageGenerator on GPU bots
2016-02-08 bungeman SkTArray to move when moving.
2016-02-08 bsalomon Replace GrGLInterface's function pointers with std::functions.
2016-02-08 joshualitt Create image cache for use by json canvas
2016-02-08 mtklein simplify piex.gyp

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=kjlubick@google.com

Committed: https://crrev.com/25634af9690a239e3f51b683eb2e303aae4d8136
Cr-Commit-Position: refs/heads/master@{#374323}

[skia-deps-roller, 2016-02-09 04:44:15]

The CQ bit was checked by skia-deps-roller@chromium.org

[commit-bot: I haz the power, 2016-02-09 04:46:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680563005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680563005/1

[commit-bot: I haz the power, 2016-02-09 06:29:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-09 06:31:11]

Description was changed from

==========
Roll src/third_party/skia/ 629f25a7e..81bb79b7b (23 commits).

https://chromium.googlesource.com/skia.git/+log/629f25a7ef22..81bb79b7b979

$ git log 629f25a7e..81bb79b7b --date=short --no-merges --format='%ad %ae %s'
2016-02-08 mtklein Remove SkNx AVX code.  It is not really used.  Getting in the
way of refactoring.
2016-02-08 scroggo Optionally run RAW images serially
2016-02-08 mtklein DM: this must have been missing from the previous CL
2016-02-08 joshualitt Skia serve now supports favicon correctly
2016-02-08 brianosman Support --dryRun in nanobench to get a list of benchmarks.
2016-02-08 msarett Optimize CMYK->RGBA (BGRA) transform for jpeg decodes
2016-02-08 reed extend modecolorfilter to 4f
2016-02-08 mtklein dm: simplify parallel/serial decisions
2016-02-08 sheyang Reland of whitespace change to test bugdroid (patchset #1
id:1 of https://codereview.chromium.org/1673083003/ )
2016-02-08 reed remove dead SK_SUPPORT_LEGACY_NEG_SCALE_HQ flag
2016-02-08 msarett Blacklist RAW images on GPU tests
2016-02-08 ethannicholas Revert of Moved Canvas->JSON and JSON->Canvas
functionality into SkDebugCanvas. (patchset #2 id:20001 of
https://codereview.chromium.org/1681643002/ )
2016-02-08 ethannicholas Moved Canvas->JSON and JSON->Canvas functionality into
SkDebugCanvas. SkJSONCanvas and SkJSONRenderer will be deleted once the debug
server has been updated. GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
2016-02-08 kjlubick Reland of SkTArray to move when moving. (patchset #1 id:1 of
https://codereview.chromium.org/1677103002/ )
2016-02-08 cdalton Improve GLSL integer support
2016-02-08 kjlubick Revert of SkTArray to move when moving. (patchset #3
id:40001 of https://codereview.chromium.org/1672063002/ )
2016-02-08 mtklein msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex
2016-02-08 halcanary SkDeflateWStream: support gzip output
2016-02-08 msarett Test CodecImageGenerator on GPU bots
2016-02-08 bungeman SkTArray to move when moving.
2016-02-08 bsalomon Replace GrGLInterface's function pointers with
std::functions.
2016-02-08 joshualitt Create image cache for use by json canvas
2016-02-08 mtklein simplify piex.gyp


CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=kjlubick@google.com
==========

to

==========
Roll src/third_party/skia/ 629f25a7e..81bb79b7b (23 commits).

https://chromium.googlesource.com/skia.git/+log/629f25a7ef22..81bb79b7b979

$ git log 629f25a7e..81bb79b7b --date=short --no-merges --format='%ad %ae %s'
2016-02-08 mtklein Remove SkNx AVX code.  It is not really used.  Getting in the
way of refactoring.
2016-02-08 scroggo Optionally run RAW images serially
2016-02-08 mtklein DM: this must have been missing from the previous CL
2016-02-08 joshualitt Skia serve now supports favicon correctly
2016-02-08 brianosman Support --dryRun in nanobench to get a list of benchmarks.
2016-02-08 msarett Optimize CMYK->RGBA (BGRA) transform for jpeg decodes
2016-02-08 reed extend modecolorfilter to 4f
2016-02-08 mtklein dm: simplify parallel/serial decisions
2016-02-08 sheyang Reland of whitespace change to test bugdroid (patchset #1
id:1 of https://codereview.chromium.org/1673083003/ )
2016-02-08 reed remove dead SK_SUPPORT_LEGACY_NEG_SCALE_HQ flag
2016-02-08 msarett Blacklist RAW images on GPU tests
2016-02-08 ethannicholas Revert of Moved Canvas->JSON and JSON->Canvas
functionality into SkDebugCanvas. (patchset #2 id:20001 of
https://codereview.chromium.org/1681643002/ )
2016-02-08 ethannicholas Moved Canvas->JSON and JSON->Canvas functionality into
SkDebugCanvas. SkJSONCanvas and SkJSONRenderer will be deleted once the debug
server has been updated. GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
2016-02-08 kjlubick Reland of SkTArray to move when moving. (patchset #1 id:1 of
https://codereview.chromium.org/1677103002/ )
2016-02-08 cdalton Improve GLSL integer support
2016-02-08 kjlubick Revert of SkTArray to move when moving. (patchset #3
id:40001 of https://codereview.chromium.org/1672063002/ )
2016-02-08 mtklein msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex
2016-02-08 halcanary SkDeflateWStream: support gzip output
2016-02-08 msarett Test CodecImageGenerator on GPU bots
2016-02-08 bungeman SkTArray to move when moving.
2016-02-08 bsalomon Replace GrGLInterface's function pointers with
std::functions.
2016-02-08 joshualitt Create image cache for use by json canvas
2016-02-08 mtklein simplify piex.gyp

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=kjlubick@google.com

Committed: https://crrev.com/25634af9690a239e3f51b683eb2e303aae4d8136
Cr-Commit-Position: refs/heads/master@{#374323}
==========

[commit-bot: I haz the power, 2016-02-09 06:31:12]

Patchset 1 (id:??) landed as
https://crrev.com/25634af9690a239e3f51b683eb2e303aae4d8136
Cr-Commit-Position: refs/heads/master@{#374323}

[Nico, 2016-02-09 12:08:50]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1685563002/ by thakis@chromium.org.

The reason for reverting is: Still breaks clang/win bots:

In file included from
..\..\third_party\skia\src\ports\SkRemotableFontMgr_win_dw.cpp:11:
In file included from
..\..\third_party\skia\src\utils\win\SkDWriteFontFileStream.h:14:
In file included from ..\..\third_party\skia\include\core\SkStream.h:225:
In file included from ..\..\third_party\skia\include\core\SkString.h:14:
..\..\third_party\skia\include\core\SkTArray.h(417,39) :  error: no matching
constructor for initialization of 'SkRemotableFontMgr_DirectWrite::DataId'
            new (dst + sizeof(T) * i) T(std::move(fItemArray[i]));
                                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~
..\..\third_party\skia\include\core\SkTArray.h(458,19) :  note: in instantiation
of function template specialization
'SkTArray<SkRemotableFontMgr_DirectWrite::DataId, false>::move<false>' requested
here
            this->move(newMemArray);
                  ^
..\..\third_party\skia\include\core\SkTArray.h(427,15) :  note: in instantiation
of member function 'SkTArray<SkRemotableFontMgr_DirectWrite::DataId,
false>::checkRealloc' requested here
        this->checkRealloc(n);
              ^
..\..\third_party\skia\include\core\SkTArray.h(147,46) :  note: in instantiation
of member function 'SkTArray<SkRemotableFontMgr_DirectWrite::DataId,
false>::push_back_raw' requested here
        T* newT = reinterpret_cast<T*>(this->push_back_raw(1));
                                             ^
..\..\third_party\skia\src\ports\SkRemotableFontMgr_win_dw.cpp(75,38) :  note:
in instantiation of member function
'SkTArray<SkRemotableFontMgr_DirectWrite::DataId, false>::push_back' requested
here
        DataId& added = fDataIdCache.push_back();
                                     ^
..\..\third_party\skia\src\ports\SkRemotableFontMgr_win_dw.cpp(36,18) :  note:
candidate constructor not viable: expects an l-value for 1st argument
        explicit DataId(DataId& that)
                 ^
..\..\third_party\skia\src\ports\SkRemotableFontMgr_win_dw.cpp(33,9) :  note:
candidate constructor not viable: requires 0 arguments, but 1 was provided
        DataId() { }
        ^.

I hit "Stop" on autoroll.skia.org until this is resolved..

[mtklein, 2016-02-09 13:14:48]

On 2016/02/09 12:08:50, Nico wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1685563002/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is: Still breaks clang/win bots:
> 
> In file included from
> ..\..\third_party\skia\src\ports\SkRemotableFontMgr_win_dw.cpp:11:
> In file included from
> ..\..\third_party\skia\src\utils\win\SkDWriteFontFileStream.h:14:
> In file included from ..\..\third_party\skia\include\core\SkStream.h:225:
> In file included from ..\..\third_party\skia\include\core\SkString.h:14:
> ..\..\third_party\skia\include\core\SkTArray.h(417,39) :  error: no matching
> constructor for initialization of 'SkRemotableFontMgr_DirectWrite::DataId'
>             new (dst + sizeof(T) * i) T(std::move(fItemArray[i]));
>                                       ^ ~~~~~~~~~~~~~~~~~~~~~~~~
> ..\..\third_party\skia\include\core\SkTArray.h(458,19) :  note: in
instantiation
> of function template specialization
> 'SkTArray<SkRemotableFontMgr_DirectWrite::DataId, false>::move<false>'
requested
> here
>             this->move(newMemArray);
>                   ^
> ..\..\third_party\skia\include\core\SkTArray.h(427,15) :  note: in
instantiation
> of member function 'SkTArray<SkRemotableFontMgr_DirectWrite::DataId,
> false>::checkRealloc' requested here
>         this->checkRealloc(n);
>               ^
> ..\..\third_party\skia\include\core\SkTArray.h(147,46) :  note: in
instantiation
> of member function 'SkTArray<SkRemotableFontMgr_DirectWrite::DataId,
> false>::push_back_raw' requested here
>         T* newT = reinterpret_cast<T*>(this->push_back_raw(1));
>                                              ^
> ..\..\third_party\skia\src\ports\SkRemotableFontMgr_win_dw.cpp(75,38) :  note:
> in instantiation of member function
> 'SkTArray<SkRemotableFontMgr_DirectWrite::DataId, false>::push_back' requested
> here
>         DataId& added = fDataIdCache.push_back();
>                                      ^
> ..\..\third_party\skia\src\ports\SkRemotableFontMgr_win_dw.cpp(36,18) :  note:
> candidate constructor not viable: expects an l-value for 1st argument
>         explicit DataId(DataId& that)
>                  ^
> ..\..\third_party\skia\src\ports\SkRemotableFontMgr_win_dw.cpp(33,9) :  note:
> candidate constructor not viable: requires 0 arguments, but 1 was provided
>         DataId() { }
>         ^.
> 
> I hit "Stop" on http://autoroll.skia.org until this is resolved..

Thanks!  Pretty sure I've got the culprit reverted and will try again.
Is there a Win/Clang trybot we can add to our CQ?